diff options
author | Igor Murashkin <iam@google.com> | 2013-03-21 20:58:29 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2013-03-21 20:58:30 +0000 |
commit | f760a1b26a907f4f5b133dde66880bb666540c42 (patch) | |
tree | 84ee69166607205bca10bde1eee891b2c4e7fd28 | |
parent | 3a29ea87c8fdcd45987bcc9cd2b68961ac971d27 (diff) | |
parent | b08a63931f22a1e934b32e8fb8de9ab4877d5258 (diff) | |
download | frameworks_av-f760a1b26a907f4f5b133dde66880bb666540c42.zip frameworks_av-f760a1b26a907f4f5b133dde66880bb666540c42.tar.gz frameworks_av-f760a1b26a907f4f5b133dde66880bb666540c42.tar.bz2 |
Merge changes Ic92924ce,I53107a39 into jb-mr2-dev
* changes:
Camera2: getSceneMode should return NULL when there are no supported scene modes
commandStartFaceDetectionL returned the wrong value when face detection is not supported by the HAL. This caused the JNI function to fail since it expected a BAD_VALUE response in that case.
-rw-r--r-- | services/camera/libcameraservice/Camera2Client.cpp | 2 | ||||
-rw-r--r-- | services/camera/libcameraservice/camera2/Parameters.cpp | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/services/camera/libcameraservice/Camera2Client.cpp b/services/camera/libcameraservice/Camera2Client.cpp index 056271d..d3adbdc 100644 --- a/services/camera/libcameraservice/Camera2Client.cpp +++ b/services/camera/libcameraservice/Camera2Client.cpp @@ -1255,7 +1255,7 @@ status_t Camera2Client::commandStartFaceDetectionL(int /*type*/) { ANDROID_STATISTICS_FACE_DETECT_MODE_OFF) { ALOGE("%s: Camera %d: Face detection not supported", __FUNCTION__, mCameraId); - return INVALID_OPERATION; + return BAD_VALUE; } if (l.mParameters.enableFaceDetect) return OK; diff --git a/services/camera/libcameraservice/camera2/Parameters.cpp b/services/camera/libcameraservice/camera2/Parameters.cpp index 859e2e9..d13fe8b 100644 --- a/services/camera/libcameraservice/camera2/Parameters.cpp +++ b/services/camera/libcameraservice/camera2/Parameters.cpp @@ -534,6 +534,8 @@ status_t Parameters::initialize(const CameraMetadata *info) { if (!noSceneModes) { params.set(CameraParameters::KEY_SUPPORTED_SCENE_MODES, supportedSceneModes); + } else { + params.remove(CameraParameters::KEY_SCENE_MODE); } } |