diff options
author | Jeff Tinker <jtinker@google.com> | 2015-09-21 19:06:14 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-09-21 19:06:14 +0000 |
commit | 7b642b085413ffd92caa07933b21bc00b55f9905 (patch) | |
tree | 700f844f74c0005e7189792d38e95f41ef7e06b0 /drm | |
parent | a323e9c20b3e3a9d49278b2eb95be8318a480608 (diff) | |
parent | 0af5008096c9562f63808e37a60e5df150137526 (diff) | |
download | frameworks_av-7b642b085413ffd92caa07933b21bc00b55f9905.zip frameworks_av-7b642b085413ffd92caa07933b21bc00b55f9905.tar.gz frameworks_av-7b642b085413ffd92caa07933b21bc00b55f9905.tar.bz2 |
am 0af50080: am 8ba28c84: am d61dbb36: am 38281f1c: am d386c5be: Merge "Fix heap data leak vulnerability" into klp-dev
* commit '0af5008096c9562f63808e37a60e5df150137526':
Fix heap data leak vulnerability
Diffstat (limited to 'drm')
-rw-r--r-- | drm/common/IDrmManagerService.cpp | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/drm/common/IDrmManagerService.cpp b/drm/common/IDrmManagerService.cpp index db41e0b..c235201 100644 --- a/drm/common/IDrmManagerService.cpp +++ b/drm/common/IDrmManagerService.cpp @@ -741,9 +741,11 @@ status_t BpDrmManagerService::decrypt( const status_t status = reply.readInt32(); ALOGV("Return value of decrypt() is %d", status); - const int size = reply.readInt32(); - (*decBuffer)->length = size; - reply.read((void *)(*decBuffer)->data, size); + if (status == NO_ERROR) { + const int size = reply.readInt32(); + (*decBuffer)->length = size; + reply.read((void *)(*decBuffer)->data, size); + } return status; } @@ -1438,9 +1440,11 @@ status_t BnDrmManagerService::onTransact( reply->writeInt32(status); - const int size = decBuffer->length; - reply->writeInt32(size); - reply->write(decBuffer->data, size); + if (status == NO_ERROR) { + const int size = decBuffer->length; + reply->writeInt32(size); + reply->write(decBuffer->data, size); + } clearDecryptHandle(&handle); delete encBuffer; encBuffer = NULL; |