diff options
| author | James Dong <jdong@google.com> | 2012-02-02 15:07:52 -0800 |
|---|---|---|
| committer | James Dong <jdong@google.com> | 2012-02-02 15:13:56 -0800 |
| commit | 8bcc65c753085fe3328592cceda0cf0e8f8b0a45 (patch) | |
| tree | f7f9cff24dbf50e02f135b65bc1041e534c39d9c /include/media/stagefright/MPEG4Writer.h | |
| parent | 2af955b7437ac5345d75a5e528ebbb749667af7e (diff) | |
| download | frameworks_av-8bcc65c753085fe3328592cceda0cf0e8f8b0a45.zip frameworks_av-8bcc65c753085fe3328592cceda0cf0e8f8b0a45.tar.gz frameworks_av-8bcc65c753085fe3328592cceda0cf0e8f8b0a45.tar.bz2 | |
Don't call virtual functions in destructors for the writer classes
Have not found any concrete bugs related to these calls yet, but we should avoid
calling virtual functions in destructors, regardless.
Change-Id: I2d47b79d3fb2d29f418619bee83aa147d232a5d4
Diffstat (limited to 'include/media/stagefright/MPEG4Writer.h')
| -rw-r--r-- | include/media/stagefright/MPEG4Writer.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/media/stagefright/MPEG4Writer.h b/include/media/stagefright/MPEG4Writer.h index 77166ed..0409b30 100644 --- a/include/media/stagefright/MPEG4Writer.h +++ b/include/media/stagefright/MPEG4Writer.h @@ -37,7 +37,7 @@ public: virtual status_t addSource(const sp<MediaSource> &source); virtual status_t start(MetaData *param = NULL); - virtual status_t stop(); + virtual status_t stop() { return reset(); } virtual status_t pause(); virtual bool reachedEOS(); virtual status_t dump(int fd, const Vector<String16>& args); @@ -184,6 +184,7 @@ private: void writeLongitude(int degreex10000); void sendSessionSummary(); void release(); + status_t reset(); MPEG4Writer(const MPEG4Writer &); MPEG4Writer &operator=(const MPEG4Writer &); |