diff options
| author | Glenn Kasten <gkasten@google.com> | 2013-02-13 14:46:45 -0800 |
|---|---|---|
| committer | Glenn Kasten <gkasten@google.com> | 2013-02-14 14:35:29 -0800 |
| commit | 5881f18029deb80eb83ea88046d0593441be79c7 (patch) | |
| tree | 3de394e4626f829fed4237e756489e0fba865236 /include | |
| parent | 7e1e1e61fca5334e11a0c26ab23e6122e742d517 (diff) | |
| download | frameworks_av-5881f18029deb80eb83ea88046d0593441be79c7.zip frameworks_av-5881f18029deb80eb83ea88046d0593441be79c7.tar.gz frameworks_av-5881f18029deb80eb83ea88046d0593441be79c7.tar.bz2 | |
Temporary additional logging to investigate bug
The bug appears related to continuing to use an invalid buffer provider
in fast mixer after track destruction, so focus the added logs in that area.
Also includes a bug fix: was calling log in an unsafe place
near Threads.cpp AudioFlinger::PlaybackThread::createTrack_l line 1250.
Details:
- include caller pid or client pid where appropriate
- increase log buffer size
- log mFastIndex when AudioMixer sees an invalid bufferProvider.
- log both potentially modified and actually modified tracks in FastMixer.
- fix benign bug where sq->end() was called more than once.
- log StateQueue push() call and return.
- increase StateQueue size from 4 to 8 entries
- log mixer->enable(), bufferProvider, and currentTrackMask
- log buffer provider addresses
- increase fast mixer log buffer again
- check logf format vs. argument list compatibility
- add logging to AudioMixer
- add checking of magic field in AudioMixer to detect overwrites
- add bool AudioMixer::enabled()
Bug: 6490974
Change-Id: I1f3f18aa62d9fbd35bc32285b669f5ba40efe28e
Diffstat (limited to 'include')
| -rw-r--r-- | include/media/nbaio/NBLog.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/media/nbaio/NBLog.h b/include/media/nbaio/NBLog.h index 8fc417f..107ba66 100644 --- a/include/media/nbaio/NBLog.h +++ b/include/media/nbaio/NBLog.h @@ -115,7 +115,7 @@ public: virtual ~Writer() { } virtual void log(const char *string); - virtual void logf(const char *fmt, ...); + virtual void logf(const char *fmt, ...) __attribute__ ((format (printf, 2, 3))); virtual void logvf(const char *fmt, va_list ap); virtual void logTimestamp(); virtual void logTimestamp(const struct timespec& ts); @@ -149,7 +149,7 @@ public: LockedWriter(size_t size, void *shared); virtual void log(const char *string); - virtual void logf(const char *fmt, ...); + virtual void logf(const char *fmt, ...) __attribute__ ((format (printf, 2, 3))); virtual void logvf(const char *fmt, va_list ap); virtual void logTimestamp(); virtual void logTimestamp(const struct timespec& ts); |