diff options
author | Marco Nelissen <marcone@google.com> | 2012-10-17 10:57:02 -0700 |
---|---|---|
committer | Marco Nelissen <marcone@google.com> | 2012-10-17 10:57:02 -0700 |
commit | a4fe9a13c432afc5d1e94a4617b75e8f962540e9 (patch) | |
tree | 378f10b114a866dbe5feb3eaf7ee35f0a33f3aa2 /media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c | |
parent | bbe11e46faf8f9e3296431993c36d3efc61337b5 (diff) | |
download | frameworks_av-a4fe9a13c432afc5d1e94a4617b75e8f962540e9.zip frameworks_av-a4fe9a13c432afc5d1e94a4617b75e8f962540e9.tar.gz frameworks_av-a4fe9a13c432afc5d1e94a4617b75e8f962540e9.tar.bz2 |
Fix valgrind issues
We were reading some uninitialized memory when creating bass boost and EQ
effects, and using memcpy() with identical source and destination.
Change-Id: I15ea1b2c52ae05cbf54aef04351e89805e0ebf8e
Diffstat (limited to 'media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c')
-rw-r--r-- | media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c b/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c index 3b3c07c..32c4ce0 100644 --- a/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c +++ b/media/libeffects/lvm/lib/Bass/src/LVDBE_Init.c @@ -232,6 +232,10 @@ LVDBE_ReturnStatus_en LVDBE_Init(LVDBE_Handle_t *phInstance, pInstance->pData->AGCInstance.AGC_Gain = pInstance->pData->AGCInstance.AGC_MaxGain; /* Default to the bass boost setting */ + // initialize the mixer with some fixes values since otherwise LVDBE_SetVolume ends up + // reading uninitialized data + pMixer_Instance = &pInstance->pData->BypassVolume; + LVC_Mixer_Init(&pMixer_Instance->MixerStream[0],0x00007FFF,0x00007FFF); /* * Initialise the volume @@ -242,7 +246,6 @@ LVDBE_ReturnStatus_en LVDBE_Init(LVDBE_Handle_t *phInstance, pInstance->pData->AGCInstance.Volume = pInstance->pData->AGCInstance.Target; /* Initialise as the target */ - pMixer_Instance = &pInstance->pData->BypassVolume; MixGain = LVC_Mixer_GetTarget(&pMixer_Instance->MixerStream[0]); LVC_Mixer_Init(&pMixer_Instance->MixerStream[0],MixGain,MixGain); |