diff options
| author | Marco Nelissen <marcone@google.com> | 2012-10-17 10:57:02 -0700 |
|---|---|---|
| committer | Marco Nelissen <marcone@google.com> | 2012-10-17 10:57:02 -0700 |
| commit | 97bb6e89845cb6d85f4d34a4efcc1de2ce585336 (patch) | |
| tree | 6b8936f6a6e8d89c3a5a940fb5a48964463f4ea0 /media/libeffects/lvm/lib/Eq | |
| parent | 9bccfb551d79a16e23278db7b0e043da79118bf8 (diff) | |
| download | frameworks_av-97bb6e89845cb6d85f4d34a4efcc1de2ce585336.zip frameworks_av-97bb6e89845cb6d85f4d34a4efcc1de2ce585336.tar.gz frameworks_av-97bb6e89845cb6d85f4d34a4efcc1de2ce585336.tar.bz2 | |
Fix valgrind issues
We were reading some uninitialized memory when creating bass boost and EQ
effects, and using memcpy() with identical source and destination.
Change-Id: I15ea1b2c52ae05cbf54aef04351e89805e0ebf8e
Diffstat (limited to 'media/libeffects/lvm/lib/Eq')
| -rw-r--r-- | media/libeffects/lvm/lib/Eq/src/LVEQNB_Init.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/media/libeffects/lvm/lib/Eq/src/LVEQNB_Init.c b/media/libeffects/lvm/lib/Eq/src/LVEQNB_Init.c index e83e515..c4767a8 100644 --- a/media/libeffects/lvm/lib/Eq/src/LVEQNB_Init.c +++ b/media/libeffects/lvm/lib/Eq/src/LVEQNB_Init.c @@ -264,6 +264,9 @@ LVEQNB_ReturnStatus_en LVEQNB_Init(LVEQNB_Handle_t *phInstance, MemSize = (pCapabilities->MaxBands * sizeof(LVEQNB_BandDef_t)); pInstance->pBandDefinitions = (LVEQNB_BandDef_t *)InstAlloc_AddMember(&AllocMem, MemSize); + // clear all the bands, setting their gain to 0, otherwise when applying new params, + // it will compare against uninitialized values + memset(pInstance->pBandDefinitions, 0, MemSize); MemSize = (pCapabilities->MaxBands * sizeof(LVEQNB_BiquadType_en)); pInstance->pBiquadType = (LVEQNB_BiquadType_en *)InstAlloc_AddMember(&AllocMem, MemSize); |