summaryrefslogtreecommitdiffstats
path: root/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
diff options
context:
space:
mode:
authorMarco Nelissen <marcone@google.com>2012-10-17 10:57:02 -0700
committerMarco Nelissen <marcone@google.com>2012-10-17 10:57:02 -0700
commit97bb6e89845cb6d85f4d34a4efcc1de2ce585336 (patch)
tree6b8936f6a6e8d89c3a5a940fb5a48964463f4ea0 /media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
parent9bccfb551d79a16e23278db7b0e043da79118bf8 (diff)
downloadframeworks_av-97bb6e89845cb6d85f4d34a4efcc1de2ce585336.zip
frameworks_av-97bb6e89845cb6d85f4d34a4efcc1de2ce585336.tar.gz
frameworks_av-97bb6e89845cb6d85f4d34a4efcc1de2ce585336.tar.bz2
Fix valgrind issues
We were reading some uninitialized memory when creating bass boost and EQ effects, and using memcpy() with identical source and destination. Change-Id: I15ea1b2c52ae05cbf54aef04351e89805e0ebf8e
Diffstat (limited to 'media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp')
-rw-r--r--media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp b/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
index 2eae7df..d706c2d 100644
--- a/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
+++ b/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
@@ -2737,7 +2737,7 @@ int Effect_process(effect_handle_t self,
outBuffer->s16[i] =
clamp16((LVM_INT32)outBuffer->s16[i] + (LVM_INT32)inBuffer->s16[i]);
}
- } else {
+ } else if (outBuffer->raw != inBuffer->raw) {
memcpy(outBuffer->raw, inBuffer->raw, outBuffer->frameCount*sizeof(LVM_INT16)*2);
}
}