diff options
| author | Marco Nelissen <marcone@google.com> | 2012-10-17 10:57:02 -0700 |
|---|---|---|
| committer | Marco Nelissen <marcone@google.com> | 2012-10-17 10:57:02 -0700 |
| commit | a4fe9a13c432afc5d1e94a4617b75e8f962540e9 (patch) | |
| tree | 378f10b114a866dbe5feb3eaf7ee35f0a33f3aa2 /media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp | |
| parent | bbe11e46faf8f9e3296431993c36d3efc61337b5 (diff) | |
| download | frameworks_av-a4fe9a13c432afc5d1e94a4617b75e8f962540e9.zip frameworks_av-a4fe9a13c432afc5d1e94a4617b75e8f962540e9.tar.gz frameworks_av-a4fe9a13c432afc5d1e94a4617b75e8f962540e9.tar.bz2 | |
Fix valgrind issues
We were reading some uninitialized memory when creating bass boost and EQ
effects, and using memcpy() with identical source and destination.
Change-Id: I15ea1b2c52ae05cbf54aef04351e89805e0ebf8e
Diffstat (limited to 'media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp')
| -rw-r--r-- | media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp b/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp index 2eae7df..d706c2d 100644 --- a/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp +++ b/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp @@ -2737,7 +2737,7 @@ int Effect_process(effect_handle_t self, outBuffer->s16[i] = clamp16((LVM_INT32)outBuffer->s16[i] + (LVM_INT32)inBuffer->s16[i]); } - } else { + } else if (outBuffer->raw != inBuffer->raw) { memcpy(outBuffer->raw, inBuffer->raw, outBuffer->frameCount*sizeof(LVM_INT16)*2); } } |