diff options
| author | Glenn Kasten <gkasten@google.com> | 2012-02-20 12:16:30 -0800 |
|---|---|---|
| committer | Glenn Kasten <gkasten@google.com> | 2012-07-17 11:35:16 -0700 |
| commit | a189a6883ee55cf62da1d7bf5bf5a8ab501938a4 (patch) | |
| tree | 7ab4133c0ce507e289baacf76d745de27f9e8136 /media/libmedia/AudioEffect.cpp | |
| parent | 28b76b334f92a15a2be3cc9e2f7d229a3275d1ac (diff) | |
| download | frameworks_av-a189a6883ee55cf62da1d7bf5bf5a8ab501938a4.zip frameworks_av-a189a6883ee55cf62da1d7bf5bf5a8ab501938a4.tar.gz frameworks_av-a189a6883ee55cf62da1d7bf5bf5a8ab501938a4.tar.bz2 | |
Use struct assignment instead of explicit memcpy
for POD structs effect_descriptor_t and effect_config_t
Change-Id: Ib2fc47f85fb65ed91b0abb1f87217c49b5eb571d
Diffstat (limited to 'media/libmedia/AudioEffect.cpp')
| -rw-r--r-- | media/libmedia/AudioEffect.cpp | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/media/libmedia/AudioEffect.cpp b/media/libmedia/AudioEffect.cpp index 34451ca..680604b 100644 --- a/media/libmedia/AudioEffect.cpp +++ b/media/libmedia/AudioEffect.cpp @@ -122,19 +122,12 @@ status_t AudioEffect::set(const effect_uuid_t *type, mSessionId = sessionId; memset(&mDescriptor, 0, sizeof(effect_descriptor_t)); - memcpy(&mDescriptor.type, EFFECT_UUID_NULL, sizeof(effect_uuid_t)); - memcpy(&mDescriptor.uuid, EFFECT_UUID_NULL, sizeof(effect_uuid_t)); - - if (type != NULL) { - memcpy(&mDescriptor.type, type, sizeof(effect_uuid_t)); - } - if (uuid != NULL) { - memcpy(&mDescriptor.uuid, uuid, sizeof(effect_uuid_t)); - } + mDescriptor.type = *(type != NULL ? type : EFFECT_UUID_NULL); + mDescriptor.uuid = *(uuid != NULL ? uuid : EFFECT_UUID_NULL); mIEffectClient = new EffectClient(this); - iEffect = audioFlinger->createEffect(getpid(), (effect_descriptor_t *)&mDescriptor, + iEffect = audioFlinger->createEffect(getpid(), &mDescriptor, mIEffectClient, priority, io, mSessionId, &mStatus, &mId, &enabled); if (iEffect == 0 || (mStatus != NO_ERROR && mStatus != ALREADY_EXISTS)) { |