diff options
| author | Glenn Kasten <gkasten@google.com> | 2014-01-13 09:59:31 -0800 |
|---|---|---|
| committer | Glenn Kasten <gkasten@google.com> | 2014-01-14 18:12:46 -0800 |
| commit | 5f972c031d4061f4f037c9fda1ea4bd9b6a756cd (patch) | |
| tree | f70d82aa480a0cbe854395362aba76fbb58315dc /media/libmedia/AudioRecord.cpp | |
| parent | 5b27ccd67c845aa20a12a1fb58339e7e81e3d536 (diff) | |
| download | frameworks_av-5f972c031d4061f4f037c9fda1ea4bd9b6a756cd.zip frameworks_av-5f972c031d4061f4f037c9fda1ea4bd9b6a756cd.tar.gz frameworks_av-5f972c031d4061f4f037c9fda1ea4bd9b6a756cd.tar.bz2 | |
AudioRecord::getInputFramesLost() cleanup
Fixed bug that if the binder call failed (for example if the
IAudioFlinger binder is dead), then getInputFramesLost was returning
garbage. Now it correctly returns zero, which is the error value for
this method.
The type declarations for getInputFramesLost were inconsistent:
a mixture of unsigned int, size_t, and uint32_t. Now it returns uint32_t
everywhere, which is what the underlying HAL API returns.
Added a FIXME about the side effect behavior. This will need review
for multi-client.
Change-Id: Ifa2e117a87dbd0c1f2c892a31d1c3dd919bf1a0a
Diffstat (limited to 'media/libmedia/AudioRecord.cpp')
| -rw-r--r-- | media/libmedia/AudioRecord.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/media/libmedia/AudioRecord.cpp b/media/libmedia/AudioRecord.cpp index e39a475..0a728a8 100644 --- a/media/libmedia/AudioRecord.cpp +++ b/media/libmedia/AudioRecord.cpp @@ -412,7 +412,7 @@ status_t AudioRecord::getPosition(uint32_t *position) const return NO_ERROR; } -unsigned int AudioRecord::getInputFramesLost() const +uint32_t AudioRecord::getInputFramesLost() const { // no need to check mActive, because if inactive this will return 0, which is what we want return AudioSystem::getInputFramesLost(getInput()); |