diff options
author | James Dong <jdong@google.com> | 2010-06-25 17:06:47 -0700 |
---|---|---|
committer | James Dong <jdong@google.com> | 2010-06-28 15:32:26 -0700 |
commit | 37047fceba836f341d0108beed0991b0f8dfc543 (patch) | |
tree | 6b60725c1d6af1ca91a46961bbecff9b996d07c2 /media/libmediaplayerservice | |
parent | 93d6b102a13afa23bfa80d74c399d93d542e6ad6 (diff) | |
download | frameworks_av-37047fceba836f341d0108beed0991b0f8dfc543.zip frameworks_av-37047fceba836f341d0108beed0991b0f8dfc543.tar.gz frameworks_av-37047fceba836f341d0108beed0991b0f8dfc543.tar.bz2 |
Separate MediaRecorderClient with MediaPlayerClient
- An alternative would be to define a common base class that
both MediaRecorderClient and MediaPlayerClient can derive.
But since the common code, onTransact() and notify() uses
some Binder code, having a common base class may not gain
us too much in terms of code reuse.
Change-Id: Ibc06720278ad173fceacff3d267b7060856c6316
Diffstat (limited to 'media/libmediaplayerservice')
4 files changed, 5 insertions, 5 deletions
diff --git a/media/libmediaplayerservice/MediaRecorderClient.cpp b/media/libmediaplayerservice/MediaRecorderClient.cpp index 084f039..80b1cfd 100644 --- a/media/libmediaplayerservice/MediaRecorderClient.cpp +++ b/media/libmediaplayerservice/MediaRecorderClient.cpp @@ -318,7 +318,7 @@ MediaRecorderClient::~MediaRecorderClient() release(); } -status_t MediaRecorderClient::setListener(const sp<IMediaPlayerClient>& listener) +status_t MediaRecorderClient::setListener(const sp<IMediaRecorderClient>& listener) { LOGV("setListener"); Mutex::Autolock lock(mLock); diff --git a/media/libmediaplayerservice/MediaRecorderClient.h b/media/libmediaplayerservice/MediaRecorderClient.h index e07306b..b53d950 100644 --- a/media/libmediaplayerservice/MediaRecorderClient.h +++ b/media/libmediaplayerservice/MediaRecorderClient.h @@ -40,7 +40,7 @@ public: virtual status_t setVideoSize(int width, int height); virtual status_t setVideoFrameRate(int frames_per_second); virtual status_t setParameters(const String8& params); - virtual status_t setListener(const sp<IMediaPlayerClient>& listener); + virtual status_t setListener(const sp<IMediaRecorderClient>& listener); virtual status_t prepare(); virtual status_t getMaxAmplitude(int* max); virtual status_t start(); diff --git a/media/libmediaplayerservice/StagefrightRecorder.cpp b/media/libmediaplayerservice/StagefrightRecorder.cpp index 1e20f7e..c4aeec3 100644 --- a/media/libmediaplayerservice/StagefrightRecorder.cpp +++ b/media/libmediaplayerservice/StagefrightRecorder.cpp @@ -456,7 +456,7 @@ status_t StagefrightRecorder::setParameters(const String8 ¶ms) { return OK; } -status_t StagefrightRecorder::setListener(const sp<IMediaPlayerClient> &listener) { +status_t StagefrightRecorder::setListener(const sp<IMediaRecorderClient> &listener) { mListener = listener; return OK; diff --git a/media/libmediaplayerservice/StagefrightRecorder.h b/media/libmediaplayerservice/StagefrightRecorder.h index 9fb7e8f..f4488b6 100644 --- a/media/libmediaplayerservice/StagefrightRecorder.h +++ b/media/libmediaplayerservice/StagefrightRecorder.h @@ -46,7 +46,7 @@ struct StagefrightRecorder : public MediaRecorderBase { virtual status_t setOutputFile(const char *path); virtual status_t setOutputFile(int fd, int64_t offset, int64_t length); virtual status_t setParameters(const String8& params); - virtual status_t setListener(const sp<IMediaPlayerClient>& listener); + virtual status_t setListener(const sp<IMediaRecorderClient>& listener); virtual status_t prepare(); virtual status_t start(); virtual status_t pause(); @@ -63,7 +63,7 @@ private: sp<Camera> mCamera; sp<ISurface> mPreviewSurface; - sp<IMediaPlayerClient> mListener; + sp<IMediaRecorderClient> mListener; sp<MediaWriter> mWriter; sp<AudioSource> mAudioSourceNode; |