diff options
author | Elliott Hughes <enh@google.com> | 2014-06-11 23:59:18 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2014-06-11 08:41:21 +0000 |
commit | c323737dd46d724b4c1ec230b283f26ae2a22b4f (patch) | |
tree | 71f5fa54cfecfeffdce0b738e6b78e93f91f2ee8 /media/libmediaplayerservice | |
parent | 8d6d8f546c1d6c55b79b454c720c03a80c738444 (diff) | |
parent | f3e80dddd7376aa9deeb27de25e1d50030a2ad98 (diff) | |
download | frameworks_av-c323737dd46d724b4c1ec230b283f26ae2a22b4f.zip frameworks_av-c323737dd46d724b4c1ec230b283f26ae2a22b4f.tar.gz frameworks_av-c323737dd46d724b4c1ec230b283f26ae2a22b4f.tar.bz2 |
Merge "Offer a type-safe album art interface."
Diffstat (limited to 'media/libmediaplayerservice')
-rw-r--r-- | media/libmediaplayerservice/MetadataRetrieverClient.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/media/libmediaplayerservice/MetadataRetrieverClient.cpp b/media/libmediaplayerservice/MetadataRetrieverClient.cpp index 348957f..5c9bd8f 100644 --- a/media/libmediaplayerservice/MetadataRetrieverClient.cpp +++ b/media/libmediaplayerservice/MetadataRetrieverClient.cpp @@ -230,7 +230,7 @@ sp<IMemory> MetadataRetrieverClient::extractAlbumArt() ALOGE("failed to extract an album art"); return NULL; } - size_t size = sizeof(MediaAlbumArt) + albumArt->mSize; + size_t size = sizeof(MediaAlbumArt) + albumArt->size(); sp<MemoryHeapBase> heap = new MemoryHeapBase(size, 0, "MetadataRetrieverClient"); if (heap == NULL) { ALOGE("failed to create MemoryDealer object"); @@ -243,11 +243,9 @@ sp<IMemory> MetadataRetrieverClient::extractAlbumArt() delete albumArt; return NULL; } - MediaAlbumArt *albumArtCopy = static_cast<MediaAlbumArt *>(mAlbumArt->pointer()); - albumArtCopy->mSize = albumArt->mSize; - albumArtCopy->mData = (uint8_t *)albumArtCopy + sizeof(MediaAlbumArt); - memcpy(albumArtCopy->mData, albumArt->mData, albumArt->mSize); - delete albumArt; // Fix memory leakage + MediaAlbumArt::init((MediaAlbumArt *) mAlbumArt->pointer(), + albumArt->size(), albumArt->data()); + delete albumArt; // We've taken our copy. return mAlbumArt; } |