stagefright: ACodec: Don't return success when encoders fail to init

When configureCodec fails we try to fallback to another codec that
supports the mimeType. However, this fallback is only done for
decoders and, if encoders fail, they will always end up sending
a success notification and returning true, causing mediaserver to
crash.

Change-Id: I32bee3167a8b43243cd708258435174f90f21a1b

1 files changed, 4 insertions, 4 deletions

diff --git a/media/libstagefright/ACodec.cpp b/media/libstagefright/ACodec.cpp
index a8e4e02..eddd7ba 100644
--- a/media/libstagefright/ACodec.cpp
+++ b/media/libstagefright/ACodec.cpp
@@ -5859,11 +5859,11 @@ bool ACodec::LoadedState::onConfigureComponent(
             mCodec->mComponentName = componentName;
 
             err = mCodec->configureCodec(mime.c_str(), msg);
+        }
 
-            if (err != OK) {
-                mCodec->signalError((OMX_ERRORTYPE)err, makeNoSideEffectStatus(err));
-                return false;
-            }
+        if (err != OK) {
+            mCodec->signalError((OMX_ERRORTYPE)err, makeNoSideEffectStatus(err));
+            return false;
         }
     }