diff options
| author | James Dong <jdong@google.com> | 2012-02-02 15:07:52 -0800 |
|---|---|---|
| committer | James Dong <jdong@google.com> | 2012-02-02 15:13:56 -0800 |
| commit | 8bcc65c753085fe3328592cceda0cf0e8f8b0a45 (patch) | |
| tree | f7f9cff24dbf50e02f135b65bc1041e534c39d9c /media/libstagefright/MPEG2TSWriter.cpp | |
| parent | 2af955b7437ac5345d75a5e528ebbb749667af7e (diff) | |
| download | frameworks_av-8bcc65c753085fe3328592cceda0cf0e8f8b0a45.zip frameworks_av-8bcc65c753085fe3328592cceda0cf0e8f8b0a45.tar.gz frameworks_av-8bcc65c753085fe3328592cceda0cf0e8f8b0a45.tar.bz2 | |
Don't call virtual functions in destructors for the writer classes
Have not found any concrete bugs related to these calls yet, but we should avoid
calling virtual functions in destructors, regardless.
Change-Id: I2d47b79d3fb2d29f418619bee83aa147d232a5d4
Diffstat (limited to 'media/libstagefright/MPEG2TSWriter.cpp')
| -rw-r--r-- | media/libstagefright/MPEG2TSWriter.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/media/libstagefright/MPEG2TSWriter.cpp b/media/libstagefright/MPEG2TSWriter.cpp index 36009ab..0b4ecbe 100644 --- a/media/libstagefright/MPEG2TSWriter.cpp +++ b/media/libstagefright/MPEG2TSWriter.cpp @@ -513,7 +513,7 @@ void MPEG2TSWriter::init() { MPEG2TSWriter::~MPEG2TSWriter() { if (mStarted) { - stop(); + reset(); } mLooper->unregisterHandler(mReflector->id()); @@ -564,7 +564,7 @@ status_t MPEG2TSWriter::start(MetaData *param) { return OK; } -status_t MPEG2TSWriter::stop() { +status_t MPEG2TSWriter::reset() { CHECK(mStarted); for (size_t i = 0; i < mSources.size(); ++i) { |