diff options
| author | Marco Nelissen <marcone@google.com> | 2015-10-06 17:03:00 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-10-06 17:03:00 +0000 |
| commit | 07395f4cd72cf29d1de2864cde42876db4e54411 (patch) | |
| tree | 4cd400786003a0679e9ac67cfeef7b57c4212f63 /media/libstagefright/MPEG4Extractor.cpp | |
| parent | df68d9d5bf5329bc2f7effb6afa1d3904eaf30d8 (diff) | |
| parent | 00f5fa82d884c0ca41ee08e7a67ab54238109083 (diff) | |
| download | frameworks_av-07395f4cd72cf29d1de2864cde42876db4e54411.zip frameworks_av-07395f4cd72cf29d1de2864cde42876db4e54411.tar.gz frameworks_av-07395f4cd72cf29d1de2864cde42876db4e54411.tar.bz2 | |
am 00f5fa82: am 74d1927e: Merge "Check NAL size before use" into klp-dev
* commit '00f5fa82d884c0ca41ee08e7a67ab54238109083':
Check NAL size before use
Diffstat (limited to 'media/libstagefright/MPEG4Extractor.cpp')
| -rw-r--r-- | media/libstagefright/MPEG4Extractor.cpp | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp index d9975bb..b757f94 100644 --- a/media/libstagefright/MPEG4Extractor.cpp +++ b/media/libstagefright/MPEG4Extractor.cpp @@ -3897,7 +3897,10 @@ status_t MPEG4Source::read( (const uint8_t *)mBuffer->data() + mBuffer->range_offset(); size_t nal_size = parseNALSize(src); - if (mBuffer->range_length() < mNALLengthSize + nal_size) { + if (mNALLengthSize > SIZE_MAX - nal_size) { + ALOGE("b/24441553, b/24445122"); + } + if (mBuffer->range_length() - mNALLengthSize < nal_size) { ALOGE("incomplete NAL unit."); mBuffer->release(); @@ -4184,7 +4187,11 @@ status_t MPEG4Source::fragmentedRead( (const uint8_t *)mBuffer->data() + mBuffer->range_offset(); size_t nal_size = parseNALSize(src); - if (mBuffer->range_length() < mNALLengthSize + nal_size) { + if (mNALLengthSize > SIZE_MAX - nal_size) { + ALOGE("b/24441553, b/24445122"); + } + + if (mBuffer->range_length() - mNALLengthSize < nal_size) { ALOGE("incomplete NAL unit."); mBuffer->release(); |