diff options
| author | Andreas Huber <andih@google.com> | 2012-11-20 08:52:44 -0800 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2012-11-20 08:52:44 -0800 |
| commit | 35c96b589ed8095a0d3a7dfd166b40180c0cf84c (patch) | |
| tree | af0b9c2ad79e4322ef50cd1440318bad5c982e91 /media/libstagefright/MPEG4Extractor.cpp | |
| parent | 515bb03933b7ec4e7133c0cc6de72d9abd57687f (diff) | |
| parent | 0fd2883dbe2841b7b35f1e7581e5d9d59e58ad97 (diff) | |
| download | frameworks_av-35c96b589ed8095a0d3a7dfd166b40180c0cf84c.zip frameworks_av-35c96b589ed8095a0d3a7dfd166b40180c0cf84c.tar.gz frameworks_av-35c96b589ed8095a0d3a7dfd166b40180c0cf84c.tar.bz2 | |
Merge "Handle large AVCC chunks"
Diffstat (limited to 'media/libstagefright/MPEG4Extractor.cpp')
| -rw-r--r-- | media/libstagefright/MPEG4Extractor.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp index cc71d4c..b2afec7 100644 --- a/media/libstagefright/MPEG4Extractor.cpp +++ b/media/libstagefright/MPEG4Extractor.cpp @@ -30,6 +30,7 @@ #include <string.h> #include <media/stagefright/foundation/ABitReader.h> +#include <media/stagefright/foundation/ABuffer.h> #include <media/stagefright/foundation/ADebug.h> #include <media/stagefright/foundation/AMessage.h> #include <media/stagefright/DataSource.h> @@ -1221,18 +1222,15 @@ status_t MPEG4Extractor::parseChunk(off64_t *offset, int depth) { case FOURCC('a', 'v', 'c', 'C'): { - char buffer[256]; - if (chunk_data_size > (off64_t)sizeof(buffer)) { - return ERROR_BUFFER_TOO_SMALL; - } + sp<ABuffer> buffer = new ABuffer(chunk_data_size); if (mDataSource->readAt( - data_offset, buffer, chunk_data_size) < chunk_data_size) { + data_offset, buffer->data(), chunk_data_size) < chunk_data_size) { return ERROR_IO; } mLastTrack->meta->setData( - kKeyAVCC, kTypeAVCC, buffer, chunk_data_size); + kKeyAVCC, kTypeAVCC, buffer->data(), chunk_data_size); *offset += chunk_size; break; |