diff options
| author | Marco Nelissen <marcone@google.com> | 2016-01-12 23:00:07 +0000 |
|---|---|---|
| committer | android-build-merger <android-build-merger@google.com> | 2016-01-12 23:00:07 +0000 |
| commit | e2e46f5fa1e669fb7f00b3ed2bbc37390e0a5a68 (patch) | |
| tree | e516bebf73f62bcaea63ea768ad4e09e5b2c4125 /media/libstagefright/MPEG4Extractor.cpp | |
| parent | df81fc3f3c56048a797232fa49185831f250e57c (diff) | |
| parent | a8ac8f617b2df8f07935d3e1e47189dee2381b88 (diff) | |
| download | frameworks_av-e2e46f5fa1e669fb7f00b3ed2bbc37390e0a5a68.zip frameworks_av-e2e46f5fa1e669fb7f00b3ed2bbc37390e0a5a68.tar.gz frameworks_av-e2e46f5fa1e669fb7f00b3ed2bbc37390e0a5a68.tar.bz2 | |
Fix out-of-bounds write am: 5403587a74 am: fb2eb86102 am: e6bd186c7e
am: a8ac8f617b
* commit 'a8ac8f617b2df8f07935d3e1e47189dee2381b88':
Fix out-of-bounds write
Diffstat (limited to 'media/libstagefright/MPEG4Extractor.cpp')
| -rw-r--r-- | media/libstagefright/MPEG4Extractor.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp index 2550253..dc8bed9 100644 --- a/media/libstagefright/MPEG4Extractor.cpp +++ b/media/libstagefright/MPEG4Extractor.cpp @@ -4297,7 +4297,15 @@ status_t MPEG4Source::fragmentedRead( continue; } - CHECK(dstOffset + 4 <= mBuffer->size()); + if (dstOffset > SIZE_MAX - 4 || + dstOffset + 4 > SIZE_MAX - nalLength || + dstOffset + 4 + nalLength > mBuffer->size()) { + ALOGE("b/26365349 : %zu %zu", dstOffset, mBuffer->size()); + android_errorWriteLog(0x534e4554, "26365349"); + mBuffer->release(); + mBuffer = NULL; + return ERROR_MALFORMED; + } dstData[dstOffset++] = 0; dstData[dstOffset++] = 0; |