summaryrefslogtreecommitdiffstats
path: root/media/libstagefright/MPEG4Extractor.cpp
diff options
context:
space:
mode:
authorWei Jia <wjia@google.com>2015-10-06 17:03:17 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2015-10-06 17:03:17 +0000
commitfb0d63df2393a5e20cbb16d90ed5c01295a81836 (patch)
tree2ad60dc1efbd8cd418066add38e83968f79456a9 /media/libstagefright/MPEG4Extractor.cpp
parent567ad5c622c5dd809e2fae0cec93a545723a2f86 (diff)
parent62d89908f6c7e3da9dac36aa439ceb1c2522b86d (diff)
downloadframeworks_av-fb0d63df2393a5e20cbb16d90ed5c01295a81836.zip
frameworks_av-fb0d63df2393a5e20cbb16d90ed5c01295a81836.tar.gz
frameworks_av-fb0d63df2393a5e20cbb16d90ed5c01295a81836.tar.bz2
am 62d89908: am df68d9d5: am 60b25aa0: am 9ab9c85e: Merge "MPEG4Extractor: ensure buffer size is not less than 8 for LastCommentData." into klp-dev
* commit '62d89908f6c7e3da9dac36aa439ceb1c2522b86d': MPEG4Extractor: ensure buffer size is not less than 8 for LastCommentData.
Diffstat (limited to 'media/libstagefright/MPEG4Extractor.cpp')
-rw-r--r--media/libstagefright/MPEG4Extractor.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp
index 66a3793..69eab99 100644
--- a/media/libstagefright/MPEG4Extractor.cpp
+++ b/media/libstagefright/MPEG4Extractor.cpp
@@ -2350,6 +2350,12 @@ status_t MPEG4Extractor::parseITunesMetaData(off64_t offset, size_t size) {
mLastCommentName.setTo((const char *)buffer + 4);
break;
case FOURCC('d', 'a', 't', 'a'):
+ if (size < 8) {
+ delete[] buffer;
+ buffer = NULL;
+ ALOGE("b/24346430");
+ return ERROR_MALFORMED;
+ }
mLastCommentData.setTo((const char *)buffer + 8);
break;
}