diff options
| author | Marco Nelissen <marcone@google.com> | 2016-01-12 22:54:38 +0000 |
|---|---|---|
| committer | android-build-merger <android-build-merger@google.com> | 2016-01-12 22:54:38 +0000 |
| commit | fb2eb8610208d3ad2ea69f57a151ffe436c6c6e6 (patch) | |
| tree | 32df0477abbdb5465925ed77f15681a26501b238 /media/libstagefright/MPEG4Extractor.cpp | |
| parent | baebc739b0fe7257b26bfe105b67409559171c82 (diff) | |
| parent | 5403587a74aee2fb57076528c3927851531c8afb (diff) | |
| download | frameworks_av-fb2eb8610208d3ad2ea69f57a151ffe436c6c6e6.zip frameworks_av-fb2eb8610208d3ad2ea69f57a151ffe436c6c6e6.tar.gz frameworks_av-fb2eb8610208d3ad2ea69f57a151ffe436c6c6e6.tar.bz2 | |
Fix out-of-bounds write
am: 5403587a74
* commit '5403587a74aee2fb57076528c3927851531c8afb':
Fix out-of-bounds write
Diffstat (limited to 'media/libstagefright/MPEG4Extractor.cpp')
| -rw-r--r-- | media/libstagefright/MPEG4Extractor.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/media/libstagefright/MPEG4Extractor.cpp b/media/libstagefright/MPEG4Extractor.cpp index 2f27d1e..a1eb16d 100644 --- a/media/libstagefright/MPEG4Extractor.cpp +++ b/media/libstagefright/MPEG4Extractor.cpp @@ -3878,7 +3878,15 @@ status_t MPEG4Source::fragmentedRead( continue; } - CHECK(dstOffset + 4 <= mBuffer->size()); + if (dstOffset > SIZE_MAX - 4 || + dstOffset + 4 > SIZE_MAX - nalLength || + dstOffset + 4 + nalLength > mBuffer->size()) { + ALOGE("b/26365349 : %zu %zu", dstOffset, mBuffer->size()); + android_errorWriteLog(0x534e4554, "26365349"); + mBuffer->release(); + mBuffer = NULL; + return ERROR_MALFORMED; + } dstData[dstOffset++] = 0; dstData[dstOffset++] = 0; |