diff options
author | Wei Jia <wjia@google.com> | 2015-08-13 16:34:17 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-08-13 16:34:17 +0000 |
commit | 4e86a483a12b0139a8babf4754e5de340eaccd40 (patch) | |
tree | c150a9da143c2d9ee427ef803bcf4218e90ca508 /media/libstagefright/id3/ID3.cpp | |
parent | 94f8150be2041f73c2f185f2c3622a9537d47454 (diff) | |
parent | f51115bd8e44c2779b74477277c6f6046916e7cf (diff) | |
download | frameworks_av-4e86a483a12b0139a8babf4754e5de340eaccd40.zip frameworks_av-4e86a483a12b0139a8babf4754e5de340eaccd40.tar.gz frameworks_av-4e86a483a12b0139a8babf4754e5de340eaccd40.tar.bz2 |
am f51115bd: libstagefright: fix possible overflow in ID3.
* commit 'f51115bd8e44c2779b74477277c6f6046916e7cf':
libstagefright: fix possible overflow in ID3.
Diffstat (limited to 'media/libstagefright/id3/ID3.cpp')
-rw-r--r-- | media/libstagefright/id3/ID3.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/media/libstagefright/id3/ID3.cpp b/media/libstagefright/id3/ID3.cpp index 461bf6e..fa37b40 100644 --- a/media/libstagefright/id3/ID3.cpp +++ b/media/libstagefright/id3/ID3.cpp @@ -327,7 +327,7 @@ bool ID3::removeUnsynchronizationV2_4(bool iTunesHack) { size_t oldSize = mSize; size_t offset = 0; - while (offset + 10 <= mSize) { + while (mSize >= 10 && offset <= mSize - 10) { if (!memcmp(&mData[offset], "\0\0\0\0", 4)) { break; } @@ -339,7 +339,7 @@ bool ID3::removeUnsynchronizationV2_4(bool iTunesHack) { return false; } - if (offset + dataSize + 10 > mSize) { + if (dataSize > mSize - 10 - offset) { return false; } @@ -349,6 +349,9 @@ bool ID3::removeUnsynchronizationV2_4(bool iTunesHack) { if (flags & 1) { // Strip data length indicator + if (mSize < 14 || mSize - 14 < offset) { + return false; + } memmove(&mData[offset + 10], &mData[offset + 14], mSize - offset - 14); mSize -= 4; dataSize -= 4; |