summaryrefslogtreecommitdiffstats
path: root/media/libstagefright/id3
diff options
context:
space:
mode:
authorWei Jia <wjia@google.com>2015-08-20 01:16:10 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2015-08-20 01:16:10 +0000
commita6f0b0417aa3005151757e7c8064f6328a4f5246 (patch)
treedc797fe35b6ddc5854868376034c7ad7c6819724 /media/libstagefright/id3
parent123c013b14313f7824c0787e3b034af7913f4283 (diff)
parentf153ecd2c1b503a404bbb7d1db0fcc19b7bcda0e (diff)
downloadframeworks_av-a6f0b0417aa3005151757e7c8064f6328a4f5246.zip
frameworks_av-a6f0b0417aa3005151757e7c8064f6328a4f5246.tar.gz
frameworks_av-a6f0b0417aa3005151757e7c8064f6328a4f5246.tar.bz2
am f153ecd2: am 91c71293: am 91fc84f2: am de5c4c46: am 43131299: am 1a09d352: Merge "libstagefright: check remaining data size before parsing it." into klp-dev
* commit 'f153ecd2c1b503a404bbb7d1db0fcc19b7bcda0e': libstagefright: check remaining data size before parsing it.
Diffstat (limited to 'media/libstagefright/id3')
-rw-r--r--media/libstagefright/id3/ID3.cpp3
1 files changed, 3 insertions, 0 deletions
diff --git a/media/libstagefright/id3/ID3.cpp b/media/libstagefright/id3/ID3.cpp
index a90d958..29bc9e0 100644
--- a/media/libstagefright/id3/ID3.cpp
+++ b/media/libstagefright/id3/ID3.cpp
@@ -509,6 +509,9 @@ void ID3::Iterator::getstring(String8 *id, bool otherdata) const {
return;
}
+ if (mFrameSize < getHeaderLength() + 1) {
+ return;
+ }
size_t n = mFrameSize - getHeaderLength() - 1;
if (otherdata) {
// skip past the encoding, language, and the 0 separator