summaryrefslogtreecommitdiffstats
path: root/media/libstagefright/omx/OMXNodeInstance.cpp
diff options
context:
space:
mode:
authorMarco Nelissen <marcone@google.com>2015-10-06 14:19:19 -0700
committerSteve Kondik <steve@cyngn.com>2015-11-05 21:16:19 -0800
commit60c41651b3147d4e70ad630ba0007f582d3823a1 (patch)
treed54ead2ce1cb458255922c40035772054a39f531 /media/libstagefright/omx/OMXNodeInstance.cpp
parentde04a021142f832a859a83b7826aed391a8f1961 (diff)
downloadframeworks_av-60c41651b3147d4e70ad630ba0007f582d3823a1.zip
frameworks_av-60c41651b3147d4e70ad630ba0007f582d3823a1.tar.gz
frameworks_av-60c41651b3147d4e70ad630ba0007f582d3823a1.tar.bz2
Fix benign overflow in OMXNodeInstance
Change-Id: I7470bddb7ade97143ba70c026e3b7d61dd8d97b0
Diffstat (limited to 'media/libstagefright/omx/OMXNodeInstance.cpp')
-rw-r--r--media/libstagefright/omx/OMXNodeInstance.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/media/libstagefright/omx/OMXNodeInstance.cpp b/media/libstagefright/omx/OMXNodeInstance.cpp
index 4bcc732..8687ba3 100644
--- a/media/libstagefright/omx/OMXNodeInstance.cpp
+++ b/media/libstagefright/omx/OMXNodeInstance.cpp
@@ -1594,7 +1594,8 @@ void OMXNodeInstance::removeActiveBuffer(
void OMXNodeInstance::freeActiveBuffers() {
// Make sure to count down here, as freeBuffer will in turn remove
// the active buffer from the vector...
- for (size_t i = mActiveBuffers.size(); i--;) {
+ for (size_t i = mActiveBuffers.size(); i;) {
+ i--;
freeBuffer(mActiveBuffers[i].mPortIndex, mActiveBuffers[i].mID);
}
}