diff options
| author | Joshua J. Drake <android-open-source@qoop.org> | 2015-04-10 23:34:56 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-04-10 23:34:56 +0000 |
| commit | 4a13125033f2130cadb4c48b3e6e0085d8c98829 (patch) | |
| tree | 0627c871796af4f63531b39e3130a3aea66691c2 /media/libstagefright | |
| parent | 99370d2da54d7537ffda7fef1f6ef36f8b690321 (diff) | |
| parent | 030d8d0a557097b88d6ecbf6d04823213512b620 (diff) | |
| download | frameworks_av-4a13125033f2130cadb4c48b3e6e0085d8c98829.zip frameworks_av-4a13125033f2130cadb4c48b3e6e0085d8c98829.tar.gz frameworks_av-4a13125033f2130cadb4c48b3e6e0085d8c98829.tar.bz2 | |
am 030d8d0a: Fix several ineffective integer overflow checks
* commit '030d8d0a557097b88d6ecbf6d04823213512b620':
Fix several ineffective integer overflow checks
Diffstat (limited to 'media/libstagefright')
| -rw-r--r-- | media/libstagefright/SampleTable.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/media/libstagefright/SampleTable.cpp b/media/libstagefright/SampleTable.cpp index 8dfa365..1358582 100644 --- a/media/libstagefright/SampleTable.cpp +++ b/media/libstagefright/SampleTable.cpp @@ -330,7 +330,7 @@ status_t SampleTable::setTimeToSampleParams( } mTimeToSampleCount = U32_AT(&header[4]); - uint64_t allocSize = mTimeToSampleCount * 2 * sizeof(uint32_t); + uint64_t allocSize = mTimeToSampleCount * 2 * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } @@ -376,7 +376,7 @@ status_t SampleTable::setCompositionTimeToSampleParams( } mNumCompositionTimeDeltaEntries = numEntries; - uint64_t allocSize = numEntries * 2 * sizeof(uint32_t); + uint64_t allocSize = numEntries * 2 * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } @@ -426,7 +426,7 @@ status_t SampleTable::setSyncSampleParams(off64_t data_offset, size_t data_size) ALOGV("Table of sync samples is empty or has only a single entry!"); } - uint64_t allocSize = mNumSyncSamples * sizeof(uint32_t); + uint64_t allocSize = mNumSyncSamples * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } |