summaryrefslogtreecommitdiffstats
path: root/media/libstagefright
diff options
context:
space:
mode:
authorDavid Williams <david.williams@sonymobile.com>2012-11-19 09:52:16 +0100
committerGerrit Code Review <noreply-gerritcodereview@google.com>2012-11-20 12:27:56 -0800
commit8a1016a6f4d274444379c2ed88cc32bfbdfeb346 (patch)
tree0929c350bf645a9e26568c64fa44396a3ce8f89d /media/libstagefright
parent35c96b589ed8095a0d3a7dfd166b40180c0cf84c (diff)
downloadframeworks_av-8a1016a6f4d274444379c2ed88cc32bfbdfeb346.zip
frameworks_av-8a1016a6f4d274444379c2ed88cc32bfbdfeb346.tar.gz
frameworks_av-8a1016a6f4d274444379c2ed88cc32bfbdfeb346.tar.bz2
Avoid memory leaks when handling metadata strings
Don't duplicate strings when retrieveing metadata from media files. As any requests for metadata strings would pass through the binder, this would cause the reference to the duplicate string to be lost, causing a memory leak as the duplicate would not be freed. Change-Id: I2593733472b1bb589bc502b2c11080f581015bb5
Diffstat (limited to 'media/libstagefright')
-rw-r--r--media/libstagefright/StagefrightMetadataRetriever.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/media/libstagefright/StagefrightMetadataRetriever.cpp b/media/libstagefright/StagefrightMetadataRetriever.cpp
index a2f3f13..19af4fb 100644
--- a/media/libstagefright/StagefrightMetadataRetriever.cpp
+++ b/media/libstagefright/StagefrightMetadataRetriever.cpp
@@ -433,7 +433,7 @@ const char *StagefrightMetadataRetriever::extractMetadata(int keyCode) {
return NULL;
}
- return strdup(mMetaData.valueAt(index).string());
+ return mMetaData.valueAt(index).string();
}
void StagefrightMetadataRetriever::parseMetaData() {