diff options
| author | Nick Kralevich <nnk@google.com> | 2015-04-10 23:55:55 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-04-10 23:55:55 +0000 |
| commit | 2f47bb53f65e34ba9cff66106390351440b9409b (patch) | |
| tree | eccfb80afbb97299dbac3b8c235cbb2ea8276f42 /media | |
| parent | 940189d991f9f7eb55d8a379cf6fda6ec486ceb5 (diff) | |
| parent | eb204f82afd5519eb544bf8bee692e7152820c3b (diff) | |
| download | frameworks_av-2f47bb53f65e34ba9cff66106390351440b9409b.zip frameworks_av-2f47bb53f65e34ba9cff66106390351440b9409b.tar.gz frameworks_av-2f47bb53f65e34ba9cff66106390351440b9409b.tar.bz2 | |
am eb204f82: am b919a3a3: am 64290793: Merge "Fix integer underflow in ESDS processing" into klp-dev
* commit 'eb204f82afd5519eb544bf8bee692e7152820c3b':
Fix integer underflow in ESDS processing
Diffstat (limited to 'media')
| -rw-r--r-- | media/libstagefright/ESDS.cpp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/media/libstagefright/ESDS.cpp b/media/libstagefright/ESDS.cpp index 427bf7b..8fbb57c 100644 --- a/media/libstagefright/ESDS.cpp +++ b/media/libstagefright/ESDS.cpp @@ -136,6 +136,8 @@ status_t ESDS::parseESDescriptor(size_t offset, size_t size) { --size; if (streamDependenceFlag) { + if (size < 2) + return ERROR_MALFORMED; offset += 2; size -= 2; } @@ -145,11 +147,15 @@ status_t ESDS::parseESDescriptor(size_t offset, size_t size) { return ERROR_MALFORMED; } unsigned URLlength = mData[offset]; + if (URLlength >= size) + return ERROR_MALFORMED; offset += URLlength + 1; size -= URLlength + 1; } if (OCRstreamFlag) { + if (size < 2) + return ERROR_MALFORMED; offset += 2; size -= 2; |