diff options
| author | Eric Laurent <elaurent@google.com> | 2015-03-25 20:19:07 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-03-25 20:19:07 +0000 |
| commit | 424324b327cc0b022ff8d10e03158b4594489ee7 (patch) | |
| tree | e4e301f807fd90375609266d68a484319b2feef7 /media | |
| parent | 36d15776c37a6512d452628673e6286f8d9cf89c (diff) | |
| parent | 2fdd16b3cbe1c1e53d1c4b305f4c0174b995ad1a (diff) | |
| download | frameworks_av-424324b327cc0b022ff8d10e03158b4594489ee7.zip frameworks_av-424324b327cc0b022ff8d10e03158b4594489ee7.tar.gz frameworks_av-424324b327cc0b022ff8d10e03158b4594489ee7.tar.bz2 | |
am 2fdd16b3: DO NOT MERGE - audio policy service: fix possible memory overflow
* commit '2fdd16b3cbe1c1e53d1c4b305f4c0174b995ad1a':
DO NOT MERGE - audio policy service: fix possible memory overflow
Diffstat (limited to 'media')
| -rw-r--r-- | media/libmedia/IAudioPolicyService.cpp | 22 |
1 files changed, 20 insertions, 2 deletions
diff --git a/media/libmedia/IAudioPolicyService.cpp b/media/libmedia/IAudioPolicyService.cpp index 180f5fb..fc4a787 100644 --- a/media/libmedia/IAudioPolicyService.cpp +++ b/media/libmedia/IAudioPolicyService.cpp @@ -72,6 +72,8 @@ enum { GET_PHONE_STATE }; +#define MAX_ITEMS_PER_LIST 1024 + class BpAudioPolicyService : public BpInterface<IAudioPolicyService> { public: @@ -952,10 +954,18 @@ status_t BnAudioPolicyService::onTransact( audio_port_role_t role = (audio_port_role_t)data.readInt32(); audio_port_type_t type = (audio_port_type_t)data.readInt32(); unsigned int numPortsReq = data.readInt32(); + if (numPortsReq > MAX_ITEMS_PER_LIST) { + numPortsReq = MAX_ITEMS_PER_LIST; + } unsigned int numPorts = numPortsReq; - unsigned int generation; struct audio_port *ports = (struct audio_port *)calloc(numPortsReq, sizeof(struct audio_port)); + if (ports == NULL) { + reply->writeInt32(NO_MEMORY); + reply->writeInt32(0); + return NO_ERROR; + } + unsigned int generation; status_t status = listAudioPorts(role, type, &numPorts, ports, &generation); reply->writeInt32(status); reply->writeInt32(numPorts); @@ -1009,11 +1019,19 @@ status_t BnAudioPolicyService::onTransact( case LIST_AUDIO_PATCHES: { CHECK_INTERFACE(IAudioPolicyService, data, reply); unsigned int numPatchesReq = data.readInt32(); + if (numPatchesReq > MAX_ITEMS_PER_LIST) { + numPatchesReq = MAX_ITEMS_PER_LIST; + } unsigned int numPatches = numPatchesReq; - unsigned int generation; struct audio_patch *patches = (struct audio_patch *)calloc(numPatchesReq, sizeof(struct audio_patch)); + if (patches == NULL) { + reply->writeInt32(NO_MEMORY); + reply->writeInt32(0); + return NO_ERROR; + } + unsigned int generation; status_t status = listAudioPatches(&numPatches, patches, &generation); reply->writeInt32(status); reply->writeInt32(numPatches); |