diff options
| author | Joshua J. Drake <android-open-source@qoop.org> | 2015-08-04 02:50:45 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-08-04 02:50:45 +0000 |
| commit | 4534ec1a552c125ef7eea0990a84fcefb58335b9 (patch) | |
| tree | f904c740dca3b70d784e4769c6a14a4def1dc607 /media | |
| parent | e0a65f3008ac5874106b21d03e19296c8015da41 (diff) | |
| parent | 4a5fbf74b493eb293918c41a5b5f60dd7b8ebb58 (diff) | |
| download | frameworks_av-4534ec1a552c125ef7eea0990a84fcefb58335b9.zip frameworks_av-4534ec1a552c125ef7eea0990a84fcefb58335b9.tar.gz frameworks_av-4534ec1a552c125ef7eea0990a84fcefb58335b9.tar.bz2 | |
am 4a5fbf74: am 3cc11bfc: Fix several ineffective integer overflow checks
* commit '4a5fbf74b493eb293918c41a5b5f60dd7b8ebb58':
Fix several ineffective integer overflow checks
Diffstat (limited to 'media')
| -rw-r--r-- | media/libstagefright/SampleTable.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/media/libstagefright/SampleTable.cpp b/media/libstagefright/SampleTable.cpp index 8dfa365..1358582 100644 --- a/media/libstagefright/SampleTable.cpp +++ b/media/libstagefright/SampleTable.cpp @@ -330,7 +330,7 @@ status_t SampleTable::setTimeToSampleParams( } mTimeToSampleCount = U32_AT(&header[4]); - uint64_t allocSize = mTimeToSampleCount * 2 * sizeof(uint32_t); + uint64_t allocSize = mTimeToSampleCount * 2 * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } @@ -376,7 +376,7 @@ status_t SampleTable::setCompositionTimeToSampleParams( } mNumCompositionTimeDeltaEntries = numEntries; - uint64_t allocSize = numEntries * 2 * sizeof(uint32_t); + uint64_t allocSize = numEntries * 2 * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } @@ -426,7 +426,7 @@ status_t SampleTable::setSyncSampleParams(off64_t data_offset, size_t data_size) ALOGV("Table of sync samples is empty or has only a single entry!"); } - uint64_t allocSize = mNumSyncSamples * sizeof(uint32_t); + uint64_t allocSize = mNumSyncSamples * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } |