diff options
author | Wei Jia <wjia@google.com> | 2014-12-05 15:51:20 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2014-12-05 15:51:20 +0000 |
commit | 4d82c2f0d0361cd0062c3454d557bb1064e92020 (patch) | |
tree | 5e534c7306dc6845ba4d60f733158952def13d32 /media | |
parent | 9f104ea6d1123199f1f2e88934fae939c112a9b3 (diff) | |
parent | 848b4c676c3295508b74f85947fc5243ce9466f4 (diff) | |
download | frameworks_av-4d82c2f0d0361cd0062c3454d557bb1064e92020.zip frameworks_av-4d82c2f0d0361cd0062c3454d557bb1064e92020.tar.gz frameworks_av-4d82c2f0d0361cd0062c3454d557bb1064e92020.tar.bz2 |
am 848b4c67: am 814cbb4e: Merge "ESQueue: add frame length checking in validation of ADTS header." into lmp-mr1-dev
* commit '848b4c676c3295508b74f85947fc5243ce9466f4':
ESQueue: add frame length checking in validation of ADTS header.
Diffstat (limited to 'media')
-rw-r--r-- | media/libstagefright/mpeg2ts/ESQueue.cpp | 23 |
1 files changed, 19 insertions, 4 deletions
diff --git a/media/libstagefright/mpeg2ts/ESQueue.cpp b/media/libstagefright/mpeg2ts/ESQueue.cpp index 459591d..6662569 100644 --- a/media/libstagefright/mpeg2ts/ESQueue.cpp +++ b/media/libstagefright/mpeg2ts/ESQueue.cpp @@ -170,8 +170,9 @@ static bool IsSeeminglyValidAC3Header(const uint8_t *ptr, size_t size) { return parseAC3SyncFrame(ptr, size, NULL) > 0; } -static bool IsSeeminglyValidADTSHeader(const uint8_t *ptr, size_t size) { - if (size < 3) { +static bool IsSeeminglyValidADTSHeader( + const uint8_t *ptr, size_t size, size_t *frameLength) { + if (size < 7) { // Not enough data to verify header. return false; } @@ -194,6 +195,13 @@ static bool IsSeeminglyValidADTSHeader(const uint8_t *ptr, size_t size) { return false; } + size_t frameLengthInHeader = + ((ptr[3] & 3) << 11) + (ptr[4] << 3) + ((ptr[5] >> 5) & 7); + if (frameLengthInHeader > size) { + return false; + } + + *frameLength = frameLengthInHeader; return true; } @@ -315,8 +323,10 @@ status_t ElementaryStreamQueue::appendData( } #else ssize_t startOffset = -1; + size_t frameLength; for (size_t i = 0; i < size; ++i) { - if (IsSeeminglyValidADTSHeader(&ptr[i], size - i)) { + if (IsSeeminglyValidADTSHeader( + &ptr[i], size - i, &frameLength)) { startOffset = i; break; } @@ -332,8 +342,13 @@ status_t ElementaryStreamQueue::appendData( startOffset); } + if (frameLength != size - startOffset) { + ALOGW("got ADTS AAC frame length %zd instead of %zd", + frameLength, size - startOffset); + } + data = &ptr[startOffset]; - size -= startOffset; + size = frameLength; #endif break; } |