diff options
| author | Joshua J. Drake <android-open-source@qoop.org> | 2015-04-11 00:36:32 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-04-11 00:36:32 +0000 |
| commit | 892e06d1c92e2ea4fbf0a13a785c8235382f6e23 (patch) | |
| tree | 4b016b4521573a66f2fa00b966eb9dce8359938d /media | |
| parent | de2faabb2a2dc3ea181652f4fc52d105e1023cd2 (diff) | |
| parent | 86fb91857ecaca2a0dc27abcd369c5f35203e922 (diff) | |
| download | frameworks_av-892e06d1c92e2ea4fbf0a13a785c8235382f6e23.zip frameworks_av-892e06d1c92e2ea4fbf0a13a785c8235382f6e23.tar.gz frameworks_av-892e06d1c92e2ea4fbf0a13a785c8235382f6e23.tar.bz2 | |
am 86fb9185: am 75a8776e: am 3cff4324: am 520434cd: am 24acf11d: am 4a131250: am 030d8d0a: Fix several ineffective integer overflow checks
* commit '86fb91857ecaca2a0dc27abcd369c5f35203e922':
Fix several ineffective integer overflow checks
Diffstat (limited to 'media')
| -rw-r--r-- | media/libstagefright/SampleTable.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/media/libstagefright/SampleTable.cpp b/media/libstagefright/SampleTable.cpp index bdd6d56..b572af3 100644 --- a/media/libstagefright/SampleTable.cpp +++ b/media/libstagefright/SampleTable.cpp @@ -330,7 +330,7 @@ status_t SampleTable::setTimeToSampleParams( } mTimeToSampleCount = U32_AT(&header[4]); - uint64_t allocSize = mTimeToSampleCount * 2 * sizeof(uint32_t); + uint64_t allocSize = mTimeToSampleCount * 2 * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } @@ -376,7 +376,7 @@ status_t SampleTable::setCompositionTimeToSampleParams( } mNumCompositionTimeDeltaEntries = numEntries; - uint64_t allocSize = numEntries * 2 * sizeof(uint32_t); + uint64_t allocSize = numEntries * 2 * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } @@ -426,7 +426,7 @@ status_t SampleTable::setSyncSampleParams(off64_t data_offset, size_t data_size) ALOGV("Table of sync samples is empty or has only a single entry!"); } - uint64_t allocSize = mNumSyncSamples * sizeof(uint32_t); + uint64_t allocSize = mNumSyncSamples * (uint64_t)sizeof(uint32_t); if (allocSize > SIZE_MAX) { return ERROR_OUT_OF_RANGE; } |