diff options
author | Wei Jia <wjia@google.com> | 2015-10-06 21:44:34 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-10-06 21:44:34 +0000 |
commit | d9a22c51c2f06384ec617f32e6c1e02e3207de26 (patch) | |
tree | 81fecaa1e8c176224942e285921bdf0d37c86406 /media | |
parent | bf42e44c04ca08394a98eb8dda9ae8f9096dd396 (diff) | |
parent | 39d91e7bc5c62cf7349cf34ba91ae45f9eb12283 (diff) | |
download | frameworks_av-d9a22c51c2f06384ec617f32e6c1e02e3207de26.zip frameworks_av-d9a22c51c2f06384ec617f32e6c1e02e3207de26.tar.gz frameworks_av-d9a22c51c2f06384ec617f32e6c1e02e3207de26.tar.bz2 |
am 39d91e7b: Merge "ID3: check possible integer overflow for extendedHeaderSize and paddingSize." into mnc-dev
* commit '39d91e7bc5c62cf7349cf34ba91ae45f9eb12283':
ID3: check possible integer overflow for extendedHeaderSize and paddingSize.
Diffstat (limited to 'media')
-rw-r--r-- | media/libstagefright/id3/ID3.cpp | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/media/libstagefright/id3/ID3.cpp b/media/libstagefright/id3/ID3.cpp index 00f87aa..4410579 100644 --- a/media/libstagefright/id3/ID3.cpp +++ b/media/libstagefright/id3/ID3.cpp @@ -194,6 +194,13 @@ struct id3_header { if (header.version_major == 4) { void *copy = malloc(size); + if (copy == NULL) { + free(mData); + mData = NULL; + ALOGE("b/24623447, no more memory"); + return false; + } + memcpy(copy, mData, size); bool success = removeUnsynchronizationV2_4(false /* iTunesHack */); @@ -234,7 +241,14 @@ struct id3_header { return false; } - size_t extendedHeaderSize = U32_AT(&mData[0]) + 4; + size_t extendedHeaderSize = U32_AT(&mData[0]); + if (extendedHeaderSize > SIZE_MAX - 4) { + free(mData); + mData = NULL; + ALOGE("b/24623447, extendedHeaderSize is too large"); + return false; + } + extendedHeaderSize += 4; if (extendedHeaderSize > mSize) { free(mData); @@ -252,7 +266,10 @@ struct id3_header { if (extendedHeaderSize >= 10) { size_t paddingSize = U32_AT(&mData[6]); - if (mFirstFrameOffset + paddingSize > mSize) { + if (paddingSize > SIZE_MAX - mFirstFrameOffset) { + ALOGE("b/24623447, paddingSize is too large"); + } + if (paddingSize > mSize - mFirstFrameOffset) { free(mData); mData = NULL; |