diff options
author | Jeff Tinker <jtinker@google.com> | 2015-09-17 17:04:05 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2015-09-17 17:04:05 +0000 |
commit | f43125ed08a408b02613b99f058564d97ce690cc (patch) | |
tree | bffa33718f670773303388e5e69461b1a2ff1d09 /media | |
parent | ae92251730865e0c4bc59ef2a8fe9dacb6de41b9 (diff) | |
parent | 9adc7283c84cea1be81d5bd55ce50aefa6328c6e (diff) | |
download | frameworks_av-f43125ed08a408b02613b99f058564d97ce690cc.zip frameworks_av-f43125ed08a408b02613b99f058564d97ce690cc.tar.gz frameworks_av-f43125ed08a408b02613b99f058564d97ce690cc.tar.bz2 |
Merge "Fix for security vulnerability in media server DO NOT MERGE" into klp-dev
Diffstat (limited to 'media')
-rw-r--r-- | media/libmedia/ICrypto.cpp | 24 |
1 files changed, 23 insertions, 1 deletions
diff --git a/media/libmedia/ICrypto.cpp b/media/libmedia/ICrypto.cpp index bff4639..2053c45 100644 --- a/media/libmedia/ICrypto.cpp +++ b/media/libmedia/ICrypto.cpp @@ -255,7 +255,28 @@ status_t BnCrypto::onTransact( } AString errorDetailMsg; - ssize_t result = decrypt( + ssize_t result; + + size_t sumSubsampleSizes = 0; + bool overflow = false; + for (int32_t i = 0; i < numSubSamples; ++i) { + CryptoPlugin::SubSample &ss = subSamples[i]; + if (sumSubsampleSizes <= SIZE_MAX - ss.mNumBytesOfEncryptedData) { + sumSubsampleSizes += ss.mNumBytesOfEncryptedData; + } else { + overflow = true; + } + if (sumSubsampleSizes <= SIZE_MAX - ss.mNumBytesOfClearData) { + sumSubsampleSizes += ss.mNumBytesOfClearData; + } else { + overflow = true; + } + } + + if (overflow || sumSubsampleSizes != totalSize) { + result = -EINVAL; + } else { + result = decrypt( secure, key, iv, @@ -264,6 +285,7 @@ status_t BnCrypto::onTransact( subSamples, numSubSamples, secure ? secureBufferId : dstPtr, &errorDetailMsg); + } reply->writeInt32(result); |