diff options
author | Eric Laurent <elaurent@google.com> | 2014-02-20 16:26:11 -0800 |
---|---|---|
committer | Eric Laurent <elaurent@google.com> | 2014-02-20 16:26:11 -0800 |
commit | 8ea16e4b0a7d398d26887c18675b3899de5d779d (patch) | |
tree | 7bb7efa2106401a375cfe8874b6f4bb03dfdfb28 /services/audioflinger/AudioFlinger.cpp | |
parent | 56df9ff31d583ad3eae4f279a3df550273c58e1e (diff) | |
download | frameworks_av-8ea16e4b0a7d398d26887c18675b3899de5d779d.zip frameworks_av-8ea16e4b0a7d398d26887c18675b3899de5d779d.tar.gz frameworks_av-8ea16e4b0a7d398d26887c18675b3899de5d779d.tar.bz2 |
audioflinger: fix race condition in SyncEvent callback
Now that the SyncEvent callback is implemented by the
RecordTrack instead of the RecordThread, there is a possibility
that the callback is called after the track deletion.
SyncEvent callback now uses a weak pointer instead of
a raw pointer as cookie. This allows the callback implementer to
acquire a strong reference on the object pointed to by the cookie.
Bug: 13114128.
Change-Id: Id61b8f06044ed1e52c6f7e7c666cdede68340de2
Diffstat (limited to 'services/audioflinger/AudioFlinger.cpp')
-rw-r--r-- | services/audioflinger/AudioFlinger.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp index 788559d..6f2dce3 100644 --- a/services/audioflinger/AudioFlinger.cpp +++ b/services/audioflinger/AudioFlinger.cpp @@ -2094,7 +2094,7 @@ sp<AudioFlinger::SyncEvent> AudioFlinger::createSyncEvent(AudioSystem::sync_even int triggerSession, int listenerSession, sync_event_callback_t callBack, - void *cookie) + wp<RefBase> cookie) { Mutex::Autolock _l(mLock); |