summaryrefslogtreecommitdiffstats
path: root/services/audioflinger/AudioFlinger.cpp
diff options
context:
space:
mode:
authorGlenn Kasten <gkasten@google.com>2012-02-20 12:16:30 -0800
committerGlenn Kasten <gkasten@google.com>2012-07-17 11:35:16 -0700
commita189a6883ee55cf62da1d7bf5bf5a8ab501938a4 (patch)
tree7ab4133c0ce507e289baacf76d745de27f9e8136 /services/audioflinger/AudioFlinger.cpp
parent28b76b334f92a15a2be3cc9e2f7d229a3275d1ac (diff)
downloadframeworks_av-a189a6883ee55cf62da1d7bf5bf5a8ab501938a4.zip
frameworks_av-a189a6883ee55cf62da1d7bf5bf5a8ab501938a4.tar.gz
frameworks_av-a189a6883ee55cf62da1d7bf5bf5a8ab501938a4.tar.bz2
Use struct assignment instead of explicit memcpy
for POD structs effect_descriptor_t and effect_config_t Change-Id: Ib2fc47f85fb65ed91b0abb1f87217c49b5eb571d
Diffstat (limited to 'services/audioflinger/AudioFlinger.cpp')
-rw-r--r--services/audioflinger/AudioFlinger.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp
index e7abc45..f033080 100644
--- a/services/audioflinger/AudioFlinger.cpp
+++ b/services/audioflinger/AudioFlinger.cpp
@@ -1440,7 +1440,7 @@ void AudioFlinger::ThreadBase::updateSuspendedSessions_l(const effect_uuid_t *ty
} else {
desc = new SuspendedSessionDesc();
if (type != NULL) {
- memcpy(&desc->mType, type, sizeof(effect_uuid_t));
+ desc->mType = *type;
}
sessionEffects.add(key, desc);
ALOGV("updateSuspendedSessions_l() suspend adding effect %08x", key);
@@ -7352,7 +7352,7 @@ sp<IEffect> AudioFlinger::createEffect(pid_t pid,
// 0 and the effect is not auxiliary, continue enumeration in case
// an auxiliary version of this effect type is available
found = true;
- memcpy(&d, &desc, sizeof(effect_descriptor_t));
+ d = desc;
if (sessionId != AUDIO_SESSION_OUTPUT_MIX ||
(desc.flags & EFFECT_FLAG_TYPE_MASK) == EFFECT_FLAG_TYPE_AUXILIARY) {
break;
@@ -7368,7 +7368,7 @@ sp<IEffect> AudioFlinger::createEffect(pid_t pid,
// connect to output mix (Compliance to OpenSL ES)
if (sessionId == AUDIO_SESSION_OUTPUT_MIX &&
(d.flags & EFFECT_FLAG_TYPE_MASK) != EFFECT_FLAG_TYPE_AUXILIARY) {
- memcpy(&desc, &d, sizeof(effect_descriptor_t));
+ desc = d;
}
}
@@ -7387,7 +7387,7 @@ sp<IEffect> AudioFlinger::createEffect(pid_t pid,
}
// return effect descriptor
- memcpy(pDesc, &desc, sizeof(effect_descriptor_t));
+ *pDesc = desc;
// If output is not specified try to find a matching audio session ID in one of the
// output threads.
@@ -9384,7 +9384,7 @@ void AudioFlinger::EffectChain::setEffectSuspended_l(
desc = mSuspendedEffects.valueAt(index);
} else {
desc = new SuspendedEffectDesc();
- memcpy(&desc->mType, type, sizeof(effect_uuid_t));
+ desc->mType = *type;
mSuspendedEffects.add(type->timeLow, desc);
ALOGV("setEffectSuspended_l() add entry for %08x", type->timeLow);
}