diff options
| author | Glenn Kasten <gkasten@google.com> | 2012-01-30 14:54:39 -0800 |
|---|---|---|
| committer | Glenn Kasten <gkasten@google.com> | 2012-02-03 14:42:43 -0800 |
| commit | c19e22450e6e3d07594c935c7a9522e85e909e82 (patch) | |
| tree | 2a81eb366d10425b83b6bbf9997d9c8813515ea1 /services/audioflinger/AudioMixer.h | |
| parent | 787bae0578fbaab6219ebf23494866b224d01438 (diff) | |
| download | frameworks_av-c19e22450e6e3d07594c935c7a9522e85e909e82.zip frameworks_av-c19e22450e6e3d07594c935c7a9522e85e909e82.tar.gz frameworks_av-c19e22450e6e3d07594c935c7a9522e85e909e82.tar.bz2 | |
Use virtual destructors
It turns out to be just a comment, as all except AudioMixer are RefBase.
There are only a few performance-sensitive cases where it's worth thinking
about whether you need a virtual destructor, and the headache usually
outweighs the benefit.
Change-Id: I716292f9556ec17c29ce8c76ac8ae602cb496533
Diffstat (limited to 'services/audioflinger/AudioMixer.h')
| -rw-r--r-- | services/audioflinger/AudioMixer.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/audioflinger/AudioMixer.h b/services/audioflinger/AudioMixer.h index 84f6330..40a508e 100644 --- a/services/audioflinger/AudioMixer.h +++ b/services/audioflinger/AudioMixer.h @@ -33,7 +33,7 @@ class AudioMixer public: AudioMixer(size_t frameCount, uint32_t sampleRate); - ~AudioMixer(); + /*virtual*/ ~AudioMixer(); // non-virtual saves a v-table, restore if sub-classed static const uint32_t MAX_NUM_TRACKS = 32; static const uint32_t MAX_NUM_CHANNELS = 2; |