summaryrefslogtreecommitdiffstats
path: root/services/audioflinger/Tracks.cpp
diff options
context:
space:
mode:
authorGlenn Kasten <gkasten@google.com>2014-10-02 13:37:27 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2014-10-02 13:37:27 +0000
commit0e42a8807edec5541ecac4a050459fbb72c477dc (patch)
tree8f8530d8cf592124927783b921064923c80c94ba /services/audioflinger/Tracks.cpp
parentbc6b959b0ff5f4fc83a049cba989edc0a06ae043 (diff)
parente5095be17c623de8e4b97829d33e8a16b1b7164a (diff)
downloadframeworks_av-0e42a8807edec5541ecac4a050459fbb72c477dc.zip
frameworks_av-0e42a8807edec5541ecac4a050459fbb72c477dc.tar.gz
frameworks_av-0e42a8807edec5541ecac4a050459fbb72c477dc.tar.bz2
am e5095be1: am a49c94ea: Merge "Revert "Fix uncertainty of one normal mix buffer in AudioTrack::getTimestamp"" into lmp-dev
* commit 'e5095be17c623de8e4b97829d33e8a16b1b7164a': Revert "Fix uncertainty of one normal mix buffer in AudioTrack::getTimestamp"
Diffstat (limited to 'services/audioflinger/Tracks.cpp')
-rw-r--r--services/audioflinger/Tracks.cpp10
1 files changed, 1 insertions, 9 deletions
diff --git a/services/audioflinger/Tracks.cpp b/services/audioflinger/Tracks.cpp
index b2d53cf..75190f3 100644
--- a/services/audioflinger/Tracks.cpp
+++ b/services/audioflinger/Tracks.cpp
@@ -898,15 +898,7 @@ status_t AudioFlinger::PlaybackThread::Track::getTimestamp(AudioTimestamp& times
uint32_t unpresentedFrames =
((int64_t) playbackThread->mLatchQ.mUnpresentedFrames * mSampleRate) /
playbackThread->mSampleRate;
- // FIXME Since we're using a raw pointer as the key, it is theoretically possible
- // for a brand new track to share the same address as a recently destroyed
- // track, and thus for us to get the frames released of the wrong track.
- // It is unlikely that we would be able to call getTimestamp() so quickly
- // right after creating a new track. Nevertheless, the index here should
- // be changed to something that is unique. Or use a completely different strategy.
- ssize_t i = playbackThread->mLatchQ.mFramesReleased.indexOfKey(this);
- uint32_t framesWritten = i >= 0 ?
- playbackThread->mLatchQ.mFramesReleased[i] : mAudioTrackServerProxy->framesReleased();
+ uint32_t framesWritten = mAudioTrackServerProxy->framesReleased();
bool checkPreviousTimestamp = mPreviousValid && framesWritten >= mPreviousFramesWritten;
if (framesWritten < unpresentedFrames) {
mPreviousValid = false;