summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorGlenn Kasten <gkasten@google.com>2012-11-07 14:03:00 -0800
committerGlenn Kasten <gkasten@google.com>2012-11-14 11:58:17 -0800
commit020f79fd967736d36c7ec860814e2e93866a020f (patch)
treeb0912d848ca1b2324b3be5580498ad69f65d0f8e /services
parent17158f4a36ed16c779477a56ec831da55e8128fe (diff)
downloadframeworks_av-020f79fd967736d36c7ec860814e2e93866a020f.zip
frameworks_av-020f79fd967736d36c7ec860814e2e93866a020f.tar.gz
frameworks_av-020f79fd967736d36c7ec860814e2e93866a020f.tar.bz2
Update audio comments
Change-Id: I85d7d2f6381b251db5695202fec75128883a8662
Diffstat (limited to 'services')
-rw-r--r--services/audioflinger/AudioFlinger.h6
-rw-r--r--services/audioflinger/StateQueue.h2
2 files changed, 6 insertions, 2 deletions
diff --git a/services/audioflinger/AudioFlinger.h b/services/audioflinger/AudioFlinger.h
index 8cf58b1..54cf239 100644
--- a/services/audioflinger/AudioFlinger.h
+++ b/services/audioflinger/AudioFlinger.h
@@ -861,6 +861,9 @@ private:
sp<IMemory> sharedBuffer() const { return mSharedBuffer; }
+ // framesWritten is cumulative, never reset, and is shared all tracks
+ // audioHalFrames is derived from output latency
+ // FIXME parameters not needed, could get them from the thread
bool presentationComplete(size_t framesWritten, size_t audioHalFrames);
public:
@@ -893,6 +896,7 @@ private:
bool mHasVolumeController;
size_t mPresentationCompleteFrames; // number of frames written to the
// audio HAL when this track will be fully rendered
+ // zero means not monitoring
private:
IAudioFlinger::track_flags_t mFlags;
@@ -997,7 +1001,7 @@ private:
};
- // playback track
+ // playback track, used by DuplicatingThread
class OutputTrack : public Track {
public:
diff --git a/services/audioflinger/StateQueue.h b/services/audioflinger/StateQueue.h
index c9b5111..e33b3c6 100644
--- a/services/audioflinger/StateQueue.h
+++ b/services/audioflinger/StateQueue.h
@@ -174,7 +174,7 @@ public:
#endif
private:
- static const unsigned kN = 4; // values != 4 are not supported by this code
+ static const unsigned kN = 4; // values < 4 are not supported by this code
T mStates[kN]; // written by mutator, read by observer
// "volatile" is meaningless with SMP, but here it indicates that we're using atomic ops