diff options
| author | Eino-Ville Talvala <etalvala@google.com> | 2012-10-06 13:50:31 -0700 |
|---|---|---|
| committer | Eino-Ville Talvala <etalvala@google.com> | 2012-10-06 13:50:31 -0700 |
| commit | 3d33019b95439ba8cc062633168ec8fe51ef6ad4 (patch) | |
| tree | a1d40db6aa60ba5adbf280e23f655f0b39d50536 /services | |
| parent | 3dcdc3d056c8756d690a6fa719d50aae2e4299d4 (diff) | |
| download | frameworks_av-3d33019b95439ba8cc062633168ec8fe51ef6ad4.zip frameworks_av-3d33019b95439ba8cc062633168ec8fe51ef6ad4.tar.gz frameworks_av-3d33019b95439ba8cc062633168ec8fe51ef6ad4.tar.bz2 | |
Camera2: Fix off-by-one error in ZSL selection.
Bug: 7258126
Change-Id: Ie6da4645c46a7bb0dbd11d7c6183e904f41f74fd
Diffstat (limited to 'services')
| -rw-r--r-- | services/camera/libcameraservice/camera2/ZslProcessor.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/services/camera/libcameraservice/camera2/ZslProcessor.cpp b/services/camera/libcameraservice/camera2/ZslProcessor.cpp index 5208574..1937955 100644 --- a/services/camera/libcameraservice/camera2/ZslProcessor.cpp +++ b/services/camera/libcameraservice/camera2/ZslProcessor.cpp @@ -254,11 +254,14 @@ status_t ZslProcessor::pushToReprocess(int32_t requestId) { if (mZslQueueTail != mZslQueueHead) { CameraMetadata request; size_t index = mZslQueueTail; - while (request.isEmpty() && index != mZslQueueHead) { - request = mZslQueue[index].frame; + while (index != mZslQueueHead) { + if (!mZslQueue[index].frame.isEmpty()) { + request = mZslQueue[index].frame; + break; + } index = (index + 1) % kZslBufferDepth; } - if (request.isEmpty()) { + if (index == mZslQueueHead) { ALOGV("%s: ZSL queue has no valid frames to send yet.", __FUNCTION__); return NOT_ENOUGH_DATA; |