summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorIgor Murashkin <iam@google.com>2014-03-17 22:55:38 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2014-03-17 22:55:38 +0000
commit63143ee8a0a59d73655c8eac715ae7321027fa2b (patch)
tree4be615d3440a5c7dc14c99df7164ac89534cea48 /services
parent6f62a68d69e22201a2c44b2663c8dc71fe17f0b5 (diff)
parentbd3e2e03f3ab686c52982a9e50cae853128172cf (diff)
downloadframeworks_av-63143ee8a0a59d73655c8eac715ae7321027fa2b.zip
frameworks_av-63143ee8a0a59d73655c8eac715ae7321027fa2b.tar.gz
frameworks_av-63143ee8a0a59d73655c8eac715ae7321027fa2b.tar.bz2
am bd3e2e03: camera2: Fix segfault when using null availability listener
* commit 'bd3e2e03f3ab686c52982a9e50cae853128172cf': camera2: Fix segfault when using null availability listener
Diffstat (limited to 'services')
-rw-r--r--services/camera/libcameraservice/CameraService.cpp10
1 files changed, 10 insertions, 0 deletions
diff --git a/services/camera/libcameraservice/CameraService.cpp b/services/camera/libcameraservice/CameraService.cpp
index 87027f7..f512db2 100644
--- a/services/camera/libcameraservice/CameraService.cpp
+++ b/services/camera/libcameraservice/CameraService.cpp
@@ -655,6 +655,11 @@ status_t CameraService::addListener(
const sp<ICameraServiceListener>& listener) {
ALOGV("%s: Add listener %p", __FUNCTION__, listener.get());
+ if (listener == 0) {
+ ALOGE("%s: Listener must not be null", __FUNCTION__);
+ return BAD_VALUE;
+ }
+
Mutex::Autolock lock(mServiceLock);
Vector<sp<ICameraServiceListener> >::iterator it, end;
@@ -683,6 +688,11 @@ status_t CameraService::removeListener(
const sp<ICameraServiceListener>& listener) {
ALOGV("%s: Remove listener %p", __FUNCTION__, listener.get());
+ if (listener == 0) {
+ ALOGE("%s: Listener must not be null", __FUNCTION__);
+ return BAD_VALUE;
+ }
+
Mutex::Autolock lock(mServiceLock);
Vector<sp<ICameraServiceListener> >::iterator it;