diff options
author | Yin-Chia Yeh <yinchiayeh@google.com> | 2015-01-21 01:55:28 +0000 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2015-01-21 01:55:28 +0000 |
commit | 7790a33241f773d8a99c6f27d3bde36da08d6238 (patch) | |
tree | a85022f86af269d686fd760c1d50c69f8a32acc0 /services | |
parent | 3f603dadd7e34891d215cec8ba35ab838e70185a (diff) | |
parent | 656d738cab67349f4b5a45473a0c48cf89c68fd0 (diff) | |
download | frameworks_av-7790a33241f773d8a99c6f27d3bde36da08d6238.zip frameworks_av-7790a33241f773d8a99c6f27d3bde36da08d6238.tar.gz frameworks_av-7790a33241f773d8a99c6f27d3bde36da08d6238.tar.bz2 |
am 656d738c: am a789e519: am 0c4e56d0: Camera: make sure jpeg buffer size isn\'t too small
* commit '656d738cab67349f4b5a45473a0c48cf89c68fd0':
Camera: make sure jpeg buffer size isn't too small
Diffstat (limited to 'services')
-rw-r--r-- | services/camera/libcameraservice/device3/Camera3Device.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/services/camera/libcameraservice/device3/Camera3Device.cpp b/services/camera/libcameraservice/device3/Camera3Device.cpp index bba3905..53e6fa9 100644 --- a/services/camera/libcameraservice/device3/Camera3Device.cpp +++ b/services/camera/libcameraservice/device3/Camera3Device.cpp @@ -361,16 +361,15 @@ ssize_t Camera3Device::getJpegBufferSize(uint32_t width, uint32_t height) const return BAD_VALUE; } maxJpegBufferSize = jpegBufMaxSize.data.i32[0]; + assert(kMinJpegBufferSize < maxJpegBufferSize); // Calculate final jpeg buffer size for the given resolution. float scaleFactor = ((float) (width * height)) / (maxJpegResolution.width * maxJpegResolution.height); - ssize_t jpegBufferSize = scaleFactor * maxJpegBufferSize; - // Bound the buffer size to [MIN_JPEG_BUFFER_SIZE, maxJpegBufferSize]. + ssize_t jpegBufferSize = scaleFactor * (maxJpegBufferSize - kMinJpegBufferSize) + + kMinJpegBufferSize; if (jpegBufferSize > maxJpegBufferSize) { jpegBufferSize = maxJpegBufferSize; - } else if (jpegBufferSize < kMinJpegBufferSize) { - jpegBufferSize = kMinJpegBufferSize; } return jpegBufferSize; |