diff options
author | Glenn Kasten <gkasten@google.com> | 2011-12-16 07:29:57 -0800 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2011-12-16 07:29:57 -0800 |
commit | b87c068727a15a3d3f0bfdcb758c76a097f5e869 (patch) | |
tree | 49768247c538c838564c4546bc55cb3df572b56f /services | |
parent | 255adceb85bc23de61fb138ddb474852514b3b33 (diff) | |
parent | 1c48c3c61970527b97892ab6a2daae8eaac26964 (diff) | |
download | frameworks_av-b87c068727a15a3d3f0bfdcb758c76a097f5e869.zip frameworks_av-b87c068727a15a3d3f0bfdcb758c76a097f5e869.tar.gz frameworks_av-b87c068727a15a3d3f0bfdcb758c76a097f5e869.tar.bz2 |
Merge "Simplify enable/disable mixing"
Diffstat (limited to 'services')
-rw-r--r-- | services/audioflinger/AudioFlinger.cpp | 4 | ||||
-rw-r--r-- | services/audioflinger/AudioMixer.cpp | 34 | ||||
-rw-r--r-- | services/audioflinger/AudioMixer.h | 7 |
3 files changed, 15 insertions, 30 deletions
diff --git a/services/audioflinger/AudioFlinger.cpp b/services/audioflinger/AudioFlinger.cpp index ee9f4b7..a13fddb 100644 --- a/services/audioflinger/AudioFlinger.cpp +++ b/services/audioflinger/AudioFlinger.cpp @@ -2202,7 +2202,7 @@ uint32_t AudioFlinger::MixerThread::prepareTracks_l(const SortedVector< wp<Track // XXX: these things DON'T need to be done each time mAudioMixer->setBufferProvider(track); - mAudioMixer->enable(AudioMixer::MIXING); + mAudioMixer->enable(); mAudioMixer->setParameter(param, AudioMixer::VOLUME0, (void *)left); mAudioMixer->setParameter(param, AudioMixer::VOLUME1, (void *)right); @@ -2248,7 +2248,7 @@ uint32_t AudioFlinger::MixerThread::prepareTracks_l(const SortedVector< wp<Track mixerStatus = MIXER_TRACKS_ENABLED; } } - mAudioMixer->disable(AudioMixer::MIXING); + mAudioMixer->disable(); } } diff --git a/services/audioflinger/AudioMixer.cpp b/services/audioflinger/AudioMixer.cpp index 45f1869..f302b2f 100644 --- a/services/audioflinger/AudioMixer.cpp +++ b/services/audioflinger/AudioMixer.cpp @@ -143,36 +143,22 @@ void AudioMixer::deleteTrackName(int name) } } -status_t AudioMixer::enable(int name) +void AudioMixer::enable() { - switch (name) { - case MIXING: { - if (mState.tracks[ mActiveTrack ].enabled != 1) { - mState.tracks[ mActiveTrack ].enabled = 1; - ALOGV("enable(%d)", mActiveTrack); - invalidateState(1<<mActiveTrack); - } - } break; - default: - return NAME_NOT_FOUND; + if (mState.tracks[ mActiveTrack ].enabled != 1) { + mState.tracks[ mActiveTrack ].enabled = 1; + ALOGV("enable(%d)", mActiveTrack); + invalidateState(1<<mActiveTrack); } - return NO_ERROR; } -status_t AudioMixer::disable(int name) +void AudioMixer::disable() { - switch (name) { - case MIXING: { - if (mState.tracks[ mActiveTrack ].enabled != 0) { - mState.tracks[ mActiveTrack ].enabled = 0; - ALOGV("disable(%d)", mActiveTrack); - invalidateState(1<<mActiveTrack); - } - } break; - default: - return NAME_NOT_FOUND; + if (mState.tracks[ mActiveTrack ].enabled != 0) { + mState.tracks[ mActiveTrack ].enabled = 0; + ALOGV("disable(%d)", mActiveTrack); + invalidateState(1<<mActiveTrack); } - return NO_ERROR; } status_t AudioMixer::setActiveTrack(int track) diff --git a/services/audioflinger/AudioMixer.h b/services/audioflinger/AudioMixer.h index da9e2b5..02722d7 100644 --- a/services/audioflinger/AudioMixer.h +++ b/services/audioflinger/AudioMixer.h @@ -50,8 +50,7 @@ public: // track units (32 units) TRACK0 = 0x1000, - // enable/disable - MIXING = 0x2000, + // 0x2000 is unused // setParameter targets TRACK = 0x3000, @@ -78,8 +77,8 @@ public: int getTrackName(); void deleteTrackName(int name); - status_t enable(int name); - status_t disable(int name); + void enable(); + void disable(); status_t setActiveTrack(int track); status_t setParameter(int target, int name, void *value); |