diff options
| author | Eric Laurent <elaurent@google.com> | 2015-04-23 17:10:50 -0700 |
|---|---|---|
| committer | Eric Laurent <elaurent@google.com> | 2015-04-23 17:13:45 -0700 |
| commit | f2f79cfcdec89052f49b74f9aab48e58daf606c6 (patch) | |
| tree | e78c065329ef4f6258285c4955ae2ded5101b46d /services | |
| parent | 1ac91ed2c67245ea5052182212463d3f0afe8b5a (diff) | |
| download | frameworks_av-f2f79cfcdec89052f49b74f9aab48e58daf606c6.zip frameworks_av-f2f79cfcdec89052f49b74f9aab48e58daf606c6.tar.gz frameworks_av-f2f79cfcdec89052f49b74f9aab48e58daf606c6.tar.bz2 | |
RadioService: fix error handling in attach().
Fix typo causing tuner open error to be ignored.
Change-Id: I10735f0cf6ae64ff9c4efa2eb4b20d94d3597ae5
Diffstat (limited to 'services')
| -rw-r--r-- | services/radio/RadioService.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/services/radio/RadioService.cpp b/services/radio/RadioService.cpp index a6c2bdf..cd0f5f3 100644 --- a/services/radio/RadioService.cpp +++ b/services/radio/RadioService.cpp @@ -146,7 +146,7 @@ status_t RadioService::attach(radio_handle_t handle, radio = module->addClient(client, config, withAudio); if (radio == 0) { - NO_INIT; + return NO_INIT; } return NO_ERROR; } @@ -500,13 +500,12 @@ sp<RadioService::ModuleClient> RadioService::Module::addClient(const sp<IRadioCl if (audio) { notifyDeviceConnection(true, ""); } + ALOGV("addClient() DONE moduleClient %p", moduleClient.get()); } else { + ALOGW("%s open_tuner failed with error %d", __FUNCTION__, ret); moduleClient.clear(); } - - ALOGV("addClient() DONE moduleClient %p", moduleClient.get()); - return moduleClient; } |