| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
For build-system CFLAGS clean-up, fix unused variables.
These variables are unused in aarch64.
Bug: 18632512
Change-Id: I6ae41f64e721a0f3188f0ee045a734b366ee72a6
|
|
|
|
|
|
|
| |
For build-system CFLAGS clean-up, remove unused functions and
variables.
Change-Id: Ic3dee56b589ea9a693efa1d72ba394036efff168
|
|
|
|
|
|
|
| |
Remove extraneous parentheses - they cause compiler warnings in clang
Change-Id: Ie2efd9714f9e2251cf3b204b5c5dd1a8b8aaca13
Signed-off-by: Bernhard Rosenkränzer <Bernhard.Rosenkranzer@linaro.org>
|
|
|
|
| |
Change-Id: Ie3bae3f037730e316d7fca12e7a3527973f752ef
|
|
|
|
|
|
| |
This gets rid of initialized writeable data in the library.
Change-Id: I7c1cbeb3df10c302b645b7311591ead87a289ca1
|
|
|
|
|
|
|
| |
This avoids issues with the encoder's own definition of __inline,
which conflicts with headers brought in by string.h in glibc.
Change-Id: I9e3fbf8d892529940ea67a46e67a9abe71d9c5fa
|
|
|
|
|
|
|
|
|
| |
This doesn't maintain the exact behaviour, but seems closer to
what the original author probably intended.
This avoids a warning.
Change-Id: I191292faa0a25f715f2b7d46ec770827e2ac0b7b
|
|\
| |
| |
| |
| |
| |
| |
| | |
I00c852e4,Ib31bf028
* commit '3557654c95bae7754dcd1951ec10742b895817e2':
stagefright aacenc: Avoid overflows when calculating normFactor
stagefright aacenc: Avoid a division by zero
|
| |\
| | |
| | |
| | |
| | |
| | | |
* changes:
stagefright aacenc: Avoid overflows when calculating normFactor
stagefright aacenc: Avoid a division by zero
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
normFactor is calculated using the saturating L_add function,
but if the value added (*psfbPeFactors) is negative, the sum
can end up negative.
*psfbPeFactors can end up negative if redThrExp is less than
*psfbNActiveLines.
In cases where *psfbPeFactors ended up negative, normFactor
became INT_MIN, causing division by zero later.
Change-Id: I00c852e457b22f7eef4d6ed1887629828057206b
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In rare cases, the result of normFactor * (*psfbNActiveLines)
could be zero, leading to a division by zero in pow2_xy.
In these cases, normFactor was INT_MIN, and if *psfbNActiveLines
was 2, the product was zero.
normFactor being INT_MIN is a bug in itself though.
Change-Id: Ib31bf02889615a7be3bd1bc028da8a7651a8dbee
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
aacenc: Safeguard against overwriting bits"
* commit '715c78b933f8dec04882ebb73acd61fdd42c6c64':
stagefright aacenc: Safeguard against overwriting bits
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, if bits above the lowest noBitsToWrite were
set, they would be ORed into the previous cache word,
setting unrelated bits erroneously.
This doesn't noticeably affect the performance of the
codec as a whole.
Change-Id: Ie9935533c4299b8f07cb14485f039a9be9c84016
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
aacenc: Add prototypes for arm specific implementations of functions"
* commit '19bb62613f512b62d492fb4caf36de88fd1914dd':
stagefright aacenc: Add prototypes for arm specific implementations of functions
|
| |\ \ \
| | | | |
| | | | |
| | | | | |
of functions"
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The arm specific functions are implemented in .s files,
without any function declarations in headers.
This fixes compiler warnings about implicit declarations
of these functions.
Change-Id: I1512560b6740c1879f378886e05aaad2e3a6c869
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
aacenc: Remove a stray semicolon"
* commit '2bf76b983da1d1730d685f9907d5d4fa6ea46fcd':
stagefright aacenc: Remove a stray semicolon
|
| |\ \ \ \ |
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This avoids warnings about an empty body in an if statement.
mem_free does the same null check, so the accidental extra
semicolon was harmless, and the whole if statement actually
is needless. But if removing the if statements, all the
other ones should be removed too, for consistency.
(This could be done as a separate change).
Change-Id: I1b6064dedd15ffa949043bb5396148aaed9b43f6
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
aacenc: Don\'t address a Word32 with a Word16 pointer"
* commit '5b299d2f9038452aa09a97d4f2ce57ec20bbc06a':
stagefright aacenc: Don't address a Word32 with a Word16 pointer
|
| |\ \ \ \
| | |/ / /
| |/| | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently, a pointer to a Word32 is used as a pointer to Word16, which
doesn't work as intended on big endian architectures.
This change needs to be analyzed and tested properly so that it doesn't
cause issues with overflows in these variables. Another solution would be
to change all the scf arrays to 32 bit instead.
Change-Id: I53d9eb83bdaf8d3b1530eb5064dd10b08bce737a
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
aacenc: Make the bits to write in WriteBits unsigned"
* commit 'ed7e1e830165678421ee7d1b3dac044214a6e635':
stagefright aacenc: Make the bits to write in WriteBits unsigned
|
| |\ \ \ \
| | | |/ /
| | |/| | |
|
| | |/ /
| | | |
| | | |
| | | |
| | | |
| | | | |
They shouldn't, as far as I know, ever be a signed value.
Change-Id: I64429c7c0b2b52bec768a04d3c3eb0eb252955fa
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
aacenc: Zero-initialize a struct"
* commit '1527811984557ee0b5d6e476e84ed147e073cb45':
stagefright aacenc: Zero-initialize a struct
|
| |\ \ \ |
|
| | |/ /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This avoids using uninitialized data in some cases, according
to valgrind.
Change-Id: I2eb5242b93c4d83a1cf6a15f022ec9579e0742a4
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
aacenc: Avoid warnings about incompatible pointer types"
* commit '4de803c76d4afd0f542c086b555b71729b3c5796':
stagefright aacenc: Avoid warnings about incompatible pointer types
|
| |\ \ \ |
|
| | | |/
| | |/|
| | | |
| | | | |
Change-Id: Ida53cd1030ebb9feb0d6916e42e8ba67a90e86c7
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | | |
aacenc: Add const declarations to some pointers"
* commit '307f47aa5def85d0c0bb4af725ff557707c5be86':
stagefright aacenc: Add const declarations to some pointers
|
| |\ \ \
| | |/ /
| |/| | |
|
| | |/
| | |
| | |
| | |
| | |
| | | |
This avoids some compilation warnings.
Change-Id: Ia89ab94020a9f1ee4c1df48823fb89325cca7d36
|
|/ /
| |
| |
| |
| | |
BUG:5918479
Change-Id: I574bd5845d9e7e007c637aabbf170d03217d10ad
|
|\ \ |
|
| |/
| |
| |
| |
| |
| | |
This avoids compiler warnings about missing newlines.
Change-Id: Ieb2bb7152d794dca47c629588879032d3ba65677
|
|/
|
|
|
|
| |
This avoids a warning about /* within a comment.
Change-Id: I9079909734d35db5ab0fd54b46173d7a1848d0c9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was applied in AOSP master earlier, in commit
b21611e5b0f1797e39e781d91ade023bac87637f, but when merged
into the Google internal tree in
88c2d4d26d79384f32a25bd775cf873cb678b12a, none of these
changes have been brought in. (The diff of this merge commit
and its first parent, d94b71d, is empty.)
Therefore, reapply the rest of these changes on the files
that still are present in the current version.
Change-Id: I645a9b9134769958a11808a06163123d28d83e46
|
|\
| |
| |
| |
| |
| |
| | |
aacenc: Mark codeWord as UWord16"
* commit 'e5143d6c09f0e9a960661a2b0a5916c33fcafc4d':
stagefright aacenc: Mark codeWord as UWord16
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Without this, the codeword 0xffff will be expanded to
0xffffffff when passed as a Word32 parameter. All code words
set into this variable are UWord16 initially.
When it was expanded to 0xffffffff, it could accidentally
overwrite earlier cached bits in the bitstream writer.
Change-Id: Id91a2b8a4e934876d9cb39eaeeee323202ec8e40
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | | |
aacenc: Make the mem_malloc function 64-bit safe"
* commit 'd4dee1a57fdcd1bd1e7c621163e89039cf88d9f9':
stagefright aacenc: Make the mem_malloc function 64-bit safe
|
| |\ \
| | |/
| |/| |
|
| | |
| | |
| | |
| | | |
Change-Id: I720109133bf5e13388b26a3bdbd66ff1f5320b70
|
| |/
| |
| |
| | |
Change-Id: I3c85d8ba4cfb164455d137cdbf3b5ecc941dc6b8
|
| |
| |
| |
| | |
Change-Id: I6219725a9fbd72432bad71a176c14f26fabdbd5f
|
|/
|
|
| |
Change-Id: I6219725a9fbd72432bad71a176c14f26fabdbd5f
|
|
Change-Id: I27f387db23594e46384c4eb3a0093ce220bb6b60
|