summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristopher Tate <ctate@google.com>2009-06-04 17:01:06 -0700
committerChristopher Tate <ctate@google.com>2009-06-04 17:02:56 -0700
commit0032ce80ac127e6bfb25d727162eee4af208dc77 (patch)
treec867a73a9f4fac2e025864c3dd506334c68d6f60
parent54de90635e1d0628c396d65e6c948bf4a1529229 (diff)
downloadframeworks_base-0032ce80ac127e6bfb25d727162eee4af208dc77.zip
frameworks_base-0032ce80ac127e6bfb25d727162eee4af208dc77.tar.gz
frameworks_base-0032ce80ac127e6bfb25d727162eee4af208dc77.tar.bz2
Fix back_up_files() error detection when opening/CRCing the file
-rw-r--r--libs/utils/BackupHelpers.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/libs/utils/BackupHelpers.cpp b/libs/utils/BackupHelpers.cpp
index e8e6c45..7f423a8 100644
--- a/libs/utils/BackupHelpers.cpp
+++ b/libs/utils/BackupHelpers.cpp
@@ -350,10 +350,11 @@ back_up_files(int oldSnapshotFD, BackupDataWriter* dataStream, int newSnapshotFD
FileState& g = newSnapshot.editValueAt(m);
int fd = open(realFilename.string(), O_RDONLY);
- if (fd != -1) {
+ if (fd < 0) {
// We can't open the file. Don't report it as a delete either. Let the
// server keep the old version. Maybe they'll be able to deal with it
// on restore.
+ LOGP("Unable to open file %s - skipping", realFilename.string());
} else {
g.crc32 = compute_crc32(fd);