summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean-Baptiste Queru <jbq@google.com>2011-06-08 14:07:19 -0700
committerAndroid Git Automerger <android-git-automerger@android.com>2011-06-08 14:07:19 -0700
commit0315a2c5640dc91cd1689db9dff997e43e4effca (patch)
tree95609f53398daaafbca08fb41eba07ae0989e41c
parentae62b7b0bca9c46dea30ee81a7aada3e7576638b (diff)
parentf3894a04acb9cdd67a02a1a4c82ba7d178c13000 (diff)
downloadframeworks_base-0315a2c5640dc91cd1689db9dff997e43e4effca.zip
frameworks_base-0315a2c5640dc91cd1689db9dff997e43e4effca.tar.gz
frameworks_base-0315a2c5640dc91cd1689db9dff997e43e4effca.tar.bz2
am f3894a04: Merge "Tweak setViewport stuff for fwd-compat"
* commit 'f3894a04acb9cdd67a02a1a4c82ba7d178c13000': Tweak setViewport stuff for fwd-compat
-rw-r--r--core/jni/android/graphics/Canvas.cpp15
-rw-r--r--core/jni/android/graphics/NinePatchImpl.cpp6
2 files changed, 3 insertions, 18 deletions
diff --git a/core/jni/android/graphics/Canvas.cpp b/core/jni/android/graphics/Canvas.cpp
index c2365ff..5212548 100644
--- a/core/jni/android/graphics/Canvas.cpp
+++ b/core/jni/android/graphics/Canvas.cpp
@@ -73,20 +73,6 @@ public:
static jboolean isOpaque(JNIEnv* env, jobject jcanvas) {
NPE_CHECK_RETURN_ZERO(env, jcanvas);
SkCanvas* canvas = GraphicsJNI::getNativeCanvas(env, jcanvas);
-
- /*
- Currently we cannot support transparency in GL-based canvas' at
- the view level. Therefore we cannot base our answer on the device's
- bitmap, but need to hard-code the answer. If we relax this
- limitation in views, we can simplify the following code as well.
-
- Use the getViewport() call to find out if we're gl-based...
- */
- if (canvas->getViewport(NULL)) {
- return true;
- }
-
- // normal technique, rely on the device's bitmap for the answer
return canvas->getDevice()->accessBitmap(false).isOpaque();
}
@@ -104,7 +90,6 @@ public:
static void setViewport(JNIEnv* env, jobject, SkCanvas* canvas,
int width, int height) {
- canvas->setViewport(width, height);
}
static void setBitmap(JNIEnv* env, jobject, SkCanvas* canvas,
diff --git a/core/jni/android/graphics/NinePatchImpl.cpp b/core/jni/android/graphics/NinePatchImpl.cpp
index ff24a87..a3e36ee 100644
--- a/core/jni/android/graphics/NinePatchImpl.cpp
+++ b/core/jni/android/graphics/NinePatchImpl.cpp
@@ -116,9 +116,9 @@ void NinePatch_Draw(SkCanvas* canvas, const SkRect& bounds,
paint = &defaultPaint;
}
- // if our canvas is GL, draw this as a mesh, which will be faster than
- // in parts (which is faster for raster)
- if (canvas && canvas->getViewport(NULL)) {
+ // if our SkCanvas were back by GL we should enable this and draw this as
+ // a mesh, which will be faster in most cases.
+ if (false) {
SkNinePatch::DrawMesh(canvas, bounds, bitmap,
chunk.xDivs, chunk.numXDivs,
chunk.yDivs, chunk.numYDivs,