summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean-Baptiste Queru <jbq@google.com>2010-11-17 17:03:10 -0800
committerAndroid Code Review <code-review@android.com>2010-11-17 17:03:10 -0800
commit09e50cdbc62938b178f4c9a66b3cec8a466daaa8 (patch)
tree340aa29504021bc782b19333b8e3850ebd80649c
parent8fc378f9f59c31f4d69878277696c6a6f723af53 (diff)
parent38767b34ba056a4e384bcebc9d497da77b3a0260 (diff)
downloadframeworks_base-09e50cdbc62938b178f4c9a66b3cec8a466daaa8.zip
frameworks_base-09e50cdbc62938b178f4c9a66b3cec8a466daaa8.tar.gz
frameworks_base-09e50cdbc62938b178f4c9a66b3cec8a466daaa8.tar.bz2
Merge "Reorder lock acquision vs try."
-rw-r--r--core/java/android/database/sqlite/SQLiteCursor.java11
1 files changed, 5 insertions, 6 deletions
diff --git a/core/java/android/database/sqlite/SQLiteCursor.java b/core/java/android/database/sqlite/SQLiteCursor.java
index c7e58fa..2fd28d7 100644
--- a/core/java/android/database/sqlite/SQLiteCursor.java
+++ b/core/java/android/database/sqlite/SQLiteCursor.java
@@ -131,11 +131,11 @@ public class SQLiteCursor extends AbstractWindowedCursor {
// the cursor's state doesn't change
while (true) {
mLock.lock();
- if (mCursorState != mThreadState) {
- mLock.unlock();
- break;
- }
try {
+ if (mCursorState != mThreadState) {
+ break;
+ }
+
int count = mQuery.fillWindow(cw, mMaxRead, mCount);
// return -1 means not finished
if (count != 0) {
@@ -217,9 +217,8 @@ public class SQLiteCursor extends AbstractWindowedCursor {
mColumnNameMap = null;
mQuery = query;
+ db.lock();
try {
- db.lock();
-
// Setup the list of columns
int columnCount = mQuery.columnCountLocked();
mColumns = new String[columnCount];