summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Chalard <jchalard@google.com>2014-06-12 03:13:02 +0000
committerAndroid (Google) Code Review <android-gerrit@google.com>2014-06-10 22:29:12 +0000
commit1f3bb8477b0de925b3251933379f93ae18b06bee (patch)
tree5cfafcd0b70efc58af620b2343421d91d49bb561
parent13592c623cdd87047e68d88d87be84819292819a (diff)
parent0a993100f98e0cacaf6281214e6b54be9cd1f9fc (diff)
downloadframeworks_base-1f3bb8477b0de925b3251933379f93ae18b06bee.zip
frameworks_base-1f3bb8477b0de925b3251933379f93ae18b06bee.tar.gz
frameworks_base-1f3bb8477b0de925b3251933379f93ae18b06bee.tar.bz2
Merge "Fix a CTS test" into lmp-preview-dev
-rw-r--r--core/java/android/text/SpannableStringBuilder.java18
-rw-r--r--core/java/android/widget/TextView.java1
2 files changed, 1 insertions, 18 deletions
diff --git a/core/java/android/text/SpannableStringBuilder.java b/core/java/android/text/SpannableStringBuilder.java
index f440853..1d9aa05 100644
--- a/core/java/android/text/SpannableStringBuilder.java
+++ b/core/java/android/text/SpannableStringBuilder.java
@@ -440,26 +440,10 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable
}
// Documentation from interface
- public SpannableStringBuilder replace(int start, int end,
+ public SpannableStringBuilder replace(final int start, final int end,
CharSequence tb, int tbstart, int tbend) {
checkRange("replace", start, end);
- // Sanity check
- if (start > end) {
- Log.w(TAG, "Bad arguments to #replace : "
- + "start = " + start + ", end = " + end);
- final int tmp = start;
- start = end;
- end = tmp;
- }
- if (tbstart > tbend) {
- Log.w(TAG, "Bad arguments to #replace : "
- + "tbstart = " + tbstart + ", tbend = " + tbend);
- final int tmp = tbstart;
- tbstart = tbend;
- tbend = tmp;
- }
-
int filtercount = mFilters.length;
for (int i = 0; i < filtercount; i++) {
CharSequence repl = mFilters[i].filter(tb, tbstart, tbend, this, start, end);
diff --git a/core/java/android/widget/TextView.java b/core/java/android/widget/TextView.java
index 43c8dde..84202eb 100644
--- a/core/java/android/widget/TextView.java
+++ b/core/java/android/widget/TextView.java
@@ -5842,7 +5842,6 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener
int end = text.partialEndOffset;
if (end > N) end = N;
removeParcelableSpans(content, start, end);
- // If start > end, content.replace will swap them before using them.
content.replace(start, end, text.text);
}
}