summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndreas Huber <andih@google.com>2010-03-16 14:31:52 -0700
committerAndreas Huber <andih@google.com>2010-03-16 14:31:52 -0700
commit1fbf63abf41ca1fb9ae2c5d82088e74475279414 (patch)
tree594ef71a7c44a876980721d4a56ea9c49f64993c
parent4f33d80056dc8a185176085a211bd31f143686c4 (diff)
downloadframeworks_base-1fbf63abf41ca1fb9ae2c5d82088e74475279414.zip
frameworks_base-1fbf63abf41ca1fb9ae2c5d82088e74475279414.tar.gz
frameworks_base-1fbf63abf41ca1fb9ae2c5d82088e74475279414.tar.bz2
"isPlaying" should never block, acquiring the mutex here is unnecessary, rather than investing in a separate mutex guarding just "mFlags" we accept returning "true" from isPlaying one too many times.
Change-Id: I597577cbb3ad1afd3cb3ca91979ef24cc1a44658 related-to-bug: 2518319
-rw-r--r--media/libstagefright/AwesomePlayer.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/media/libstagefright/AwesomePlayer.cpp b/media/libstagefright/AwesomePlayer.cpp
index 10b7be3..164df72 100644
--- a/media/libstagefright/AwesomePlayer.cpp
+++ b/media/libstagefright/AwesomePlayer.cpp
@@ -624,8 +624,6 @@ status_t AwesomePlayer::pause_l() {
}
bool AwesomePlayer::isPlaying() const {
- Mutex::Autolock autoLock(mLock);
-
return mFlags & PLAYING;
}