summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChrister Fletcher <christer.fletcher@sonyericsson.com>2011-03-21 15:56:27 +0100
committerJohan Redestig <johan.redestig@sonyericsson.com>2011-03-28 14:47:55 +0200
commit375fb9bfd29ea4480aa9582bf3956b435152c8d9 (patch)
tree6780beb1c800d3f97f913e973edab38a6a088c24
parent2e383bc6445b37d3b37fbc5b7620cd4716c5692c (diff)
downloadframeworks_base-375fb9bfd29ea4480aa9582bf3956b435152c8d9.zip
frameworks_base-375fb9bfd29ea4480aa9582bf3956b435152c8d9.tar.gz
frameworks_base-375fb9bfd29ea4480aa9582bf3956b435152c8d9.tar.bz2
Handle OutOfMemoryError when decoding images in ThumbnailUtils
Added handling of OutOfMemoryError handling to createImageThumbnail method in ThumbnailUtils.java. During mediascanner run it would run out of memory when trying to decode very large images. Now it handles this error and returns null which is handled by the media scanner. Change-Id: Ie68722dfa1cedd3c0847bf483baa40c4827ad5a8
-rw-r--r--media/java/android/media/ThumbnailUtils.java4
1 files changed, 3 insertions, 1 deletions
diff --git a/media/java/android/media/ThumbnailUtils.java b/media/java/android/media/ThumbnailUtils.java
index 494b4cb..b276e33 100644
--- a/media/java/android/media/ThumbnailUtils.java
+++ b/media/java/android/media/ThumbnailUtils.java
@@ -83,7 +83,7 @@ public class ThumbnailUtils {
*
* @param filePath the path of image file
* @param kind could be MINI_KIND or MICRO_KIND
- * @return Bitmap
+ * @return Bitmap, or null on failures
*
* @hide This method is only used by media framework and media provider internally.
*/
@@ -123,6 +123,8 @@ public class ThumbnailUtils {
bitmap = BitmapFactory.decodeFileDescriptor(fd, null, options);
} catch (IOException ex) {
Log.e(TAG, "", ex);
+ } catch (OutOfMemoryError oom) {
+ Log.e(TAG, "Unable to decode file " + filePath + ". OutOfMemoryError.", oom);
}
}