diff options
| author | Andreas Huber <andih@google.com> | 2012-11-27 15:06:56 -0800 |
|---|---|---|
| committer | Andreas Huber <andih@google.com> | 2012-11-27 15:50:43 -0800 |
| commit | 585c07e9ac19060bb242067a72a570cd42c75dea (patch) | |
| tree | da63a241942313dc02822c3f8cc1a0ab6dbc8406 | |
| parent | f426ace9dab65c88b36a047bf921070edcf8cf61 (diff) | |
| download | frameworks_base-585c07e9ac19060bb242067a72a570cd42c75dea.zip frameworks_base-585c07e9ac19060bb242067a72a570cd42c75dea.tar.gz frameworks_base-585c07e9ac19060bb242067a72a570cd42c75dea.tar.bz2 | |
Stop caching stream duration, it might change (increase) dynamically.
Change-Id: Ia829f47602e6961f24464da36a0162b8c1d7d6c8
related-to-bug: 6870049
| -rw-r--r-- | core/java/android/widget/VideoView.java | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/core/java/android/widget/VideoView.java b/core/java/android/widget/VideoView.java index 7c8196d..329b0df 100644 --- a/core/java/android/widget/VideoView.java +++ b/core/java/android/widget/VideoView.java @@ -54,7 +54,6 @@ public class VideoView extends SurfaceView implements MediaPlayerControl { // settable by the client private Uri mUri; private Map<String, String> mHeaders; - private int mDuration; // all possible internal states private static final int STATE_ERROR = -1; @@ -229,7 +228,6 @@ public class VideoView extends SurfaceView implements MediaPlayerControl { mMediaPlayer = new MediaPlayer(); mMediaPlayer.setOnPreparedListener(mPreparedListener); mMediaPlayer.setOnVideoSizeChangedListener(mSizeChangedListener); - mDuration = -1; mMediaPlayer.setOnCompletionListener(mCompletionListener); mMediaPlayer.setOnErrorListener(mErrorListener); mMediaPlayer.setOnInfoListener(mOnInfoListener); @@ -608,17 +606,12 @@ public class VideoView extends SurfaceView implements MediaPlayerControl { openVideo(); } - // cache duration as mDuration for faster access public int getDuration() { if (isInPlaybackState()) { - if (mDuration > 0) { - return mDuration; - } - mDuration = mMediaPlayer.getDuration(); - return mDuration; + return mMediaPlayer.getDuration(); } - mDuration = -1; - return mDuration; + + return -1; } public int getCurrentPosition() { |
