diff options
| author | Adam Powell <adamp@google.com> | 2014-09-11 15:38:55 -0700 |
|---|---|---|
| committer | Adam Powell <adamp@google.com> | 2014-09-11 15:38:55 -0700 |
| commit | 5eb3ffc24cbcce7e0c2995d0d4be62844fef4999 (patch) | |
| tree | 163760a00801179b9e63371ff88e4afc9f223640 | |
| parent | f35423bb4e74f6cdc5e4cfc5302e659457e30f5d (diff) | |
| download | frameworks_base-5eb3ffc24cbcce7e0c2995d0d4be62844fef4999.zip frameworks_base-5eb3ffc24cbcce7e0c2995d0d4be62844fef4999.tar.gz frameworks_base-5eb3ffc24cbcce7e0c2995d0d4be62844fef4999.tar.bz2 | |
Remove View methods that can't be used safely from the SDK
View methods that previously accepted a TypedArray to initialize
parameters parsed from xml cannot be used correctly by apps. The
TypedArray passed must always be obtained from a context using the
filter array com.android.internal.R.styleable.View, which is not
visible to the SDK.
A previous change already made this safe for existing apps already
using it so that they don't crash, this change removes these methods
from the SDK entirely.
Change-Id: I62099087ad6fd5bf8363e863b04fd0434b8cdfca
| -rw-r--r-- | api/current.txt | 2 | ||||
| -rw-r--r-- | api/removed.txt | 5 | ||||
| -rw-r--r-- | core/java/android/view/View.java | 4 |
3 files changed, 9 insertions, 2 deletions
diff --git a/api/current.txt b/api/current.txt index 42eaef0..680b68b 100644 --- a/api/current.txt +++ b/api/current.txt @@ -33833,8 +33833,6 @@ package android.view { method public boolean hasTransientState(); method public boolean hasWindowFocus(); method public static android.view.View inflate(android.content.Context, int, android.view.ViewGroup); - method protected void initializeFadingEdge(android.content.res.TypedArray); - method protected void initializeScrollbars(android.content.res.TypedArray); method public void invalidate(android.graphics.Rect); method public void invalidate(int, int, int, int); method public void invalidate(); diff --git a/api/removed.txt b/api/removed.txt index c8a3b4b..3f2a5a5 100644 --- a/api/removed.txt +++ b/api/removed.txt @@ -24,6 +24,11 @@ package android.os { package android.view { + public class View implements android.view.accessibility.AccessibilityEventSource android.graphics.drawable.Drawable.Callback android.view.KeyEvent.Callback { + method protected void initializeFadingEdge(android.content.res.TypedArray); + method protected void initializeScrollbars(android.content.res.TypedArray); + } + public static class WindowManager.LayoutParams extends android.view.ViewGroup.LayoutParams implements android.os.Parcelable { field public static final int TYPE_KEYGUARD = 2004; // 0x7d4 } diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 82c5425..eb8f3bf 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -4299,6 +4299,8 @@ public class View implements Drawable.Callback, KeyEvent.Callback, * </p> * * @param a the styled attributes set to initialize the fading edges from + * + * @removed */ protected void initializeFadingEdge(TypedArray a) { // This method probably shouldn't have been included in the SDK to begin with. @@ -4439,6 +4441,8 @@ public class View implements Drawable.Callback, KeyEvent.Callback, * </p> * * @param a the styled attributes set to initialize the scrollbars from + * + * @removed */ protected void initializeScrollbars(TypedArray a) { // It's not safe to use this method from apps. The parameter 'a' must have been obtained |